Skip to content

cleanup: Remove hardcoded compiler-builtins-mem feature for armv7a-vex-v5 once compiler-builtins can automatically add it. #136076

Closed

Description

@tropicaaal

PR #131530 adds the armv7a-vex-v5 Tier 3 target, which operates outside of a libc enviornment. As such as we aren't provided symbols like memcpy, memmove, etc... and require the compiler-builtins-mem feature. In the PR, we hardcode bootstrap to automatically add the feature when target.contains("vex"). The zkvm family of targets also does this.

Once compiler-builtins is able to automatically detect the target, this check should be removed.

Activity

  1. added
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Jan 26, 2025
  2. changed the title [-]cleanup: Remove hardcoded `compiler-builtins-mem` feature addition for `armv7a-vex-v5` once `compiler-builtins` can automatically add it.[/-] [+]cleanup: Remove hardcoded `compiler-builtins-mem` feature for `armv7a-vex-v5` once `compiler-builtins` can automatically add it.[/+] on Jan 26, 2025
  3. added
    C-cleanupCategory: PRs that clean code up or issues documenting cleanup.
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    on Jan 26, 2025
  4. tropicaaal commented on Jan 26, 2025

    @tropicaaal
    ContributorAuthor

    Closing due to #131530 being closed and hopefully split into smaller changes in the future. This will be addressed at a later time.

  5. removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-cleanupCategory: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions