Repository navigation
regression: borrowed data escapes outside of the method #127342
Description
[INFO] [stdout] error[E0521]: borrowed data escapes outside of method
[INFO] [stdout] --> src/geometries/contour/difference.rs:377:43
[INFO] [stdout] |
[INFO] [stdout] 363 | fn difference(self, other: &Polygon<Scalar>) -> Self::Output {
[INFO] [stdout] | ----- - let's call the lifetime of this reference `'2`
[INFO] [stdout] | |
[INFO] [stdout] | `other` is a reference that is only valid in the method body
[INFO] [stdout] ...
[INFO] [stdout] 377 | let boxes_have_common_continuum = to_boxes_have_common_continuum(
[INFO] [stdout] | ___________________________________________^
[INFO] [stdout] 378 | | &bounding_boxes,
[INFO] [stdout] 379 | | &other_bounding_box,
[INFO] [stdout] 380 | | );
[INFO] [stdout] | | ^
[INFO] [stdout] | | |
[INFO] [stdout] | |_________`other` escapes the method body here
[INFO] [stdout] | argument requires that `'2` must outlive `'static`
[INFO] [stdout] |
[INFO] [stdout] note: due to current limitations in the borrow checker, this implies a `'static` lifetime
[INFO] [stdout] --> src/operations.rs:565:39
[INFO] [stdout] |
[INFO] [stdout] 565 | for<'a> &'a bounded::Box<Scalar>: Relatable,
[INFO] [stdout] | ^^^^^^^^^
Activity
compiler-errors commentedon Jul 4, 2024
This is (also) #119820, cc @lcnr (though we probably already have this listed as a regression in that one)
apiraino commentedon Jul 5, 2024
By reading this comment in #119820 I infer that we accepted that change but we wanted to fix all crates regressions before the release.
I'll tentatively assign a
P-high(if my understanding is correct).WG-prioritization assigning priority (Zulip discussion).
@rustbot label -I-prioritize +P-high
lqd commentedon Jul 5, 2024
This crate was indeed already fixed in lycantropos/rene#5, and this released crates.io version doesn't contain the fix.
apiraino commentedon Jul 18, 2024
Note to self: I think this issue can be closed but waiting for consensus
lcnr commentedon Jul 18, 2024
the breakage has been reverted entirely now, so regardless of the fix, this will continue to work