rust stable 1.78 using 'x86_64-pc-windows-gnu' host tool to build 'thumbv7em-none-eabihf' arm bare metal target got rust-lld failed #125809

Activity

1. pbl-pw

   added

   C-bugCategory: This is a bug.Category: This is a bug.

   on May 31, 2024
2. rustbot

   added

   needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triagingThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging

   on May 31, 2024
3. workingjubilee

   added

   O-windows-gnuToolchain: GNU, Operating system: WindowsToolchain: GNU, Operating system: Windows

   on Jun 1, 2024
4. jieyouxu

   added

   A-crossArea: Cross compilationArea: Cross compilation

   T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.

   T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

   and removed

   needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triagingThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging

   on Jun 4, 2024
5. mati865 commented on Jun 4, 2024

   

   mati865

   on Jun 4, 2024

   Member

   More actions

   Those libraries are provided alongside other Rust binaries:

   $ ls ~/.rustup/toolchains/stable-x86_64-pc-windows-gnu/bin/
   cargo.exe*         cargo-fmt.exe*      libgcc_s_seh-1.dll*   rustc.exe*                          rustdoc.exe*  rust-gdb*     rust-lldb*
   cargo-clippy.exe*  clippy-driver.exe*  libwinpthread-1.dll*  rustc_driver-35a7c4c28db0aaf0.dll*  rustfmt.exe*  rust-gdbgui*  std-a1f74822451877d1.dll*
   

   Note rust-lld is located inside rustlib:

   $ file ~/.rustup/toolchains/stable-x86_64-pc-windows-gnu/lib/rustlib/x86_64-pc-windows-gnu/bin/rust-lld.exe
   /c/Users/mateusz/.rustup/toolchains/stable-x86_64-pc-windows-gnu/lib/rustlib/x86_64-pc-windows-gnu/bin/rust-lld.exe: PE32+ executable (console) x86-64, for MS Windows, 17 sections
   

   I rust-lld should be called with PATH set to ~/.rustup/toolchains/stable-x86_64-pc-windows-gnu/bin/, or at least used to be. Do you have an example that reproduces the problem? Hopefully, we can bisect it to easily find the problem.
6. pbl-pw commented on Jun 5, 2024

   

   pbl-pw

   on Jun 5, 2024

   Author

   More actions

   I have tested using clean rust host toolchain installed by rustinit, and just build cortex-m-quickstart, then it reproduce the problem.
   note: Cargo.toml in cortex-m-quickstart need change 'package.name' and 'bin.name' before build, because they have '{{' and '}}'
7. mati865 commented on Jun 5, 2024

   

   mati865

   on Jun 5, 2024

   Last edited by mati865

   Member

   More actions

   searched nightlies: from nightly-2024-02-01 to nightly-2024-03-16
   regressed nightly: nightly-2024-02-22
   searched commit range: bb59453...3406ada
   regressed commit: 0987e41

   bisected with cargo-bisect-rustc v0.6.8

   Host triple: x86_64-pc-windows-gnu
   Reproduce with:

   cargo bisect-rustc --start=1.77.0 --end=1.78.0 --target thumbv7m-none-eabi --prompt -c rust-mingw --preserve --script C:/Program Files/Git/usr/bin/bash.exe -- ./test.sh

   Won't be as easy to debug as I hoped.
   @weihanglo do you have any idea which change could case it?

   EDIT: perhaps rust-lang/cargo#13468?
   No idea how to test it without CI builds though.
8. weihanglo commented on Jun 5, 2024

   

   weihanglo

   on Jun 5, 2024

   Last edited by weihanglo

   Member

   More actions

   If I understand correctly, when ~/.rustup/toolchains/stable-x86_64-pc-windows-gnu/bin/ is in PATH on Windows, it makes no difference. What the removed code path did was adding that to PATH. In rustup 1.27.1, RUSTUP_WINDOWS_PATH_ADD_BIN was changed to false by default (rust-lang/rustup#3703), so probably the rustup change is related.

   @mati865 is it possible for you to add RUSTUP_WINDOWS_PATH_ADD_BIN=true and check it again?
   I don't have a Windows machine available at hand :(

   Also, could you check if rustc appends host tool bin to PATH? It looks like it but I am not particularly sure.
9. weihanglo commented on Jun 5, 2024

   

   weihanglo

   on Jun 5, 2024

   Member

   More actions

   Would you mind sharing the output of rustup --version that shows the version of rustup you are using, @pbl-pw?
10. mati865 commented on Jun 5, 2024

    

    mati865

    on Jun 5, 2024

    Member

    More actions

    Thought it might be important to add; all my tests were made with only ~/.cargo/bin present in PATH:

    $ echo $PATH
    /c/Users/mateusz/.cargo/bin
    

    If I understand correctly, when ~/.rustup/toolchains/stable-x86_64-pc-windows-gnu/bin/ is in PATH on Windows, it makes no difference.

    Yes, but apparently it's not in PATH when tools from ~/.rustup/toolchains/stable-x86_64-pc-windows-gnu/lib/rustlib/x86_64-pc-windows-gnu/bin are called. $ PATH=$PATH:~/.rustup/toolchains/stable-x86_64-pc-windows-gnu/bin cargo +stable b works fine so that sort of confirms it.

    In rustup 1.27.1, RUSTUP_WINDOWS_PATH_ADD_BIN was changed to false by default (rust-lang/rustup#3703), so probably the rustup change is related.

    @mati865 is it possible for you to add RUSTUP_WINDOWS_PATH_ADD_BIN=true and check it again? I don't have a Windows machine available at hand :(

    Adding that env makes no difference:

    $ rustup -V
    rustup 1.27.1 (54dd3d00f 2024-04-24)
    info: This is the version for the rustup toolchain manager, not the rustc compiler.
    info: The currently active `rustc` version is `rustc 1.80.0-nightly (a330e4959 2024-06-04)`
    
    $ RUSTUP_WINDOWS_PATH_ADD_BIN=true cargo +stable b
    ...
    error: linking with `rust-lld` failed: exit code: 0xc0000135
    

    Also, could you check if rustc appends host tool bin to PATH? It looks like it but I am not particularly sure.

    I can do some builds during the weekend.

    Also, could you check if rustc appends host tool bin to PATH? It looks like it but I am not particularly sure.

    Judging from that code, it only adds ~/.rustup/toolchains/stable-x86_64-pc-windows-gnu/lib/rustlib/x86_64-pc-windows-gnu/bin.
11. weihanglo commented on Jun 5, 2024

    

    weihanglo

    on Jun 5, 2024

    Member

    More actions

    My fault. Should be RUSTUP_WINDOWS_PATH_ADD_BIN=1 not true.
12. mati865 commented on Jun 5, 2024

    

    mati865

    on Jun 5, 2024

    Member

    More actions

    Oh, I had missed that too 😄
    RUSTUP_WINDOWS_PATH_ADD_BIN=1 cargo +stable b works fine.
13. 4 remaining items

    Load more

14. weihanglo commented on Jun 6, 2024

    

    weihanglo

    on Jun 6, 2024

    Last edited by weihanglo

    Member

    More actions

    @ChrisDenton are you talking about a fix in cargo or rustc?
    What happens if we invoke rustc directly to cross-compile? If it doesn't work either, I feel like this should be addressed on rustc or linker invocation side.
15. mati865 commented on Jun 6, 2024

    

    mati865

    on Jun 6, 2024

    Last edited by mati865

    Member

    More actions

    Runtime libraries are located alongside rustc, so invoking it directly would work fine.
    The same cannot be said about bins inside ~/.rustup/toolchains/stable-x86_64-pc-windows-gnu/lib/rustlib/x86_64-pc-windows-gnu/bin, but is it even supported to invoke them manually?

    👍React with 👍1Reacted by Chris Denton
16. ehuss commented on Jun 6, 2024

    

    ehuss

    on Jun 6, 2024

    Contributor

    More actions

    if we invoke rustc directly to cross-compile? If it doesn't work either, I feel like this should be addressed on rustc or linker invocation side.

    This would be my inclination that rustc ensures that it has the PATH set up correctly. We just need to make sure that things like rust-lang/cargo#8531 and rust-lang/rustup#3036 don't regress again.

    I suspect adding the bin directory to PATH will make proc-macros fail recursive calls to rustc or cargo via rustup. I'm not sure how much we should care about that. The only solution I can think there is to separate the DLLs into a separate directory.

    👍React with 👍1Reacted by pbl
17. ColinFinck

    added 3 commits that reference this issue on Aug 9, 2024

    Ship MinGW-w64 runtime DLLs along with `rust-lld.exe` for `-pc-window…

    ...

    This issue will close once commit f243c37 is merged into the 'master' branch.

    f243c37

    Ship MinGW-w64 runtime DLLs along with `rust-lld.exe` for `-pc-window…

    ...

    This issue will close once commit a39d8ab is merged into the 'master' branch.

    a39d8ab

    Ship MinGW-w64 runtime DLLs along with `rust-lld.exe` for `-pc-window…

    ...

    This issue will close once commit 7fbb1cb is merged into the 'master' branch.

    7fbb1cb
18. ColinFinck commented on Aug 9, 2024

    

    ColinFinck

    on Aug 9, 2024

    Contributor

    More actions

    I'm solving this now in my PR #128876 by shipping the required runtime DLLs along with rust-lld.exe too.
    It must be possible to run rust-lld.exe without relying on any PATH variable being set. We already ship these runtime DLLs alongside rustc.exe, so doing the same for rust-lld.exe feels like a reasonable thing to do. This solution won't require RUSTUP_WINDOWS_PATH_ADD_BIN or any other modification to the PATH environment variable.
19. ColinFinck

    added 3 commits that reference this issue on Aug 13, 2024

    Ship MinGW-w64 runtime DLLs along with `rust-lld.exe` for `-pc-window…

    ...

    This issue will close once commit f94c872 is merged into the 'master' branch.

    f94c872

    Ship MinGW-w64 runtime DLLs along with `rust-lld.exe` for `-pc-window…

    ...

    This issue will close once commit a29b75a is merged into the 'master' branch.

    a29b75a

    Ship MinGW-w64 runtime DLLs along with `rust-lld.exe` for `-pc-window…

    ...

    This issue will close once commit 71d98a8 is merged into the 'master' branch.

    71d98a8
20. bors

    added a commit that references this issue on Aug 20, 2024

    Auto merge of rust-lang#128876 - ColinFinck:rust-lld-with-runtime-dll…

    ...

    This issue will close once commit 7f116c7 is merged into the 'master' branch.

    7f116c7
21. tgross35

    added a commit that references this issue on Aug 22, 2024

    Rollup merge of rust-lang#128876 - ColinFinck:rust-lld-with-runtime-d…

    ...

    This issue will close once commit 75fbcac is merged into the 'main' branch.

    75fbcac
22. matthiaskrgr

    added a commit that references this issue on Aug 23, 2024

    Rollup merge of rust-lang#128876 - ColinFinck:rust-lld-with-runtime-d…

    ...

    This issue will close once commit 6a1418a is merged into the 'master' branch.

    6a1418a
23. bors

    closed this as completedin 71d98a8on Aug 23, 2024
24. rust-timer

    added a commit that references this issue on Aug 23, 2024

    Unrolled build for rust-lang#128876

    ...

    This issue will close once commit d0b41d8 is merged into the 'master' branch.

    d0b41d8