Repository navigation
regression: cannot find macro in scope #125201
Description
- https://crater-reports.s3.amazonaws.com/beta-1.79-2/beta-2024-05-11/gh/stusmall.bowbend/log.txt
- https://crater-reports.s3.amazonaws.com/beta-1.79-2/beta-2024-05-11/gh/xupea.rust-cargo-neo/log.txt
- https://crater-reports.s3.amazonaws.com/beta-1.79-2/beta-2024-05-11/reg/bitmap-font-0.3.0/log.txt
- https://crater-reports.s3.amazonaws.com/beta-1.79-2/beta-2024-05-11/reg/dora-operator-api-types-0.3.0/log.txt
- https://crater-reports.s3.amazonaws.com/beta-1.79-2/beta-2024-05-11/reg/mls-rs-ffi-0.2.0/log.txt
- https://crater-reports.s3.amazonaws.com/beta-1.79-2/beta-2024-05-11/reg/pacaptr-0.20.1/log.txt
[INFO] [stdout] error: cannot find macro `stringified_module_code` in this scope
[INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/safer-ffi-0.1.4/src/libc.rs:9:10
[INFO] [stdout] |
[INFO] [stdout] 9 | #![doc = stringified_module_code!()]
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ consider moving the definition of `stringified_module_code` before this call
[INFO] [stdout] |
Activity
compiler-errors commentedon May 17, 2024
searched commit range: 4d570ee...aed2187
regressed commit: 35194e7
bisected with cargo-bisect-rustc v0.6.8
Host triple: x86_64-unknown-linux-gnu
Reproduce with:
Did this regress in #124382? cc @petrochenkov
compiler-errors commentedon May 17, 2024
Specifically 7517a4f seems suspicious due to title alone, didn't look into it much though.
dtolnay commentedon May 17, 2024
This was reported by one of the affected crate authors in #124535.
apiraino commentedon May 28, 2024
WG-prioritization assigning priority (Zulip discussion).
Since these crates regressed, it could probably be good to keep this on the radar (release in 15 days)
@rustbot label -I-prioritize +P-high
petrochenkov commentedon May 28, 2024
I plan to fix it later this week (#124535 is assigned to me).
petrochenkov commentedon May 29, 2024
Fixed in #125734.
danielhenrymantilla commentedon May 29, 2024
Thanks @petrochenkov! FWIW, I've since submitted a new version of
safer-ffiwhich does not rely in this AST ordering quirk: maybe that way in a few months this "breakage" can take place? I wouldn't wantsafer-ffito embody the following xkcd:petrochenkov commentedon May 29, 2024
@danielhenrymantilla
I plan to fix this properly in #125741 after the initial regression is addressed (maybe with a temporary deprecation lint), so fixing crates exploiting this bug still make sense.
Rollup merge of rust-lang#125734 - petrochenkov:macinattr, r=wesleywiser
Rollup merge of rust-lang#125734 - petrochenkov:macinattr, r=wesleywiser
Unrolled build for rust-lang#125734
lqd commentedon May 30, 2024
Reopening to track beta backport
Mark-Simulacrum commentedon Jun 7, 2024
Closing, backported to beta.
Rollup merge of #125734 - petrochenkov:macinattr, r=wesleywiser