Repository navigation
Tracking Issue for Rust 2024: rustfmt change sort to Unicode-aware "non-lowercase before lowercase" #123802
Description
This is a tracking issue for the rustfmt / T-style work needed to change the sort order to Unicode-aware "non-lowercase before lowercase" (from "ASCIIbetical") in Style Edition 2024.
About tracking issues
Tracking issues are used to record the overall progress of implementation. They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions. A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature. Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
Steps
- Implement in nightly Rust 2024.
- Add documentation to the edition guide.
- Add formatting for new syntax to the style guide.
- See the nightly style procedure.
- Ensure ready for Rust 2024 stabilization.
Unresolved Questions
None.
Implementation history
TODO.
cc @rust-lang/rustfmt @rust-lang/style @calebcartwright
Metadata
Metadata
Assignees
Labels
Area: The 2024 editionCategory: An issue tracking the progress of sth. like the implementation of an RFCStatus: This issue is ready for inclusion in the edition.Relevant to the rustfmt team, which will review and decide on the PR/issue.Relevant to the style team, which will review and decide on the PR/issue.
Activity
joshtriplett commentedon May 13, 2024
@calebcartwright @traviscross Verifying: this is labeled
T-styleandI-style-nominated, but as far as I know, this is something style already reviewed, approved, and merged into the style guide. I think this is now exclusively a matter for the rustfmt team, right?calebcartwright commentedon Jun 8, 2024
Sorry for the delayed response, but I'd agree.
#115046 covered everything we wanted to do, and it's now just down to implementation.
@traviscross the only reason I could think to keep the nominated label is so that this remains as an item that gets pulled in for the weekly check-ins?
traviscross commentedon Jun 8, 2024
That's right. Being nominated means simply that it will come up on the agenda for discussion. If that's not what we want, then we could unnominate.
However, perhaps we do want these to come up for review every week. On the lang side, we review the priority items for the edition every week, to check in on the status, and something similar seems it may be appropriate here, especially as there is remaining non-implementation work to do for many of these items, e.g. making PRs to the edition guide describing the style (and consequently rustfmt behavior) changes.
With the edition hat on, I'd prefer these to come up every week somewhere until we can mark these off the list, and so if there's not a weekly rustfmt call, then the style call seems the next best place.
traviscross commentedon Nov 19, 2024
@rustbot labels +S-tracking-ready-for-edition -I-style-nominated
We reviewed this on the edition call. This is now ready for Rust 2024.
Thanks to @calebcartwright and the rest of the rustfmt team and style team for pushing this forward.