Repository navigation
Tracking Issue for Rust 2024: rustfmt use version sort #123800
Description
This is a tracking issue for the rustfmt / T-style work needed to use version sort order in Style Edition 2024.
About tracking issues
Tracking issues are used to record the overall progress of implementation. They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions. A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature. Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
Steps
- Implement in nightly Rust 2024.
- Add documentation to the edition guide.
- Add formatting for new syntax to the style guide.
- Ensure ready for Rust 2024 stabilization.
Unresolved Questions
None.
Implementation history
- Implement version-sort for imports in
style_edition2024 rustfmt#6284 - apply 2024 version sort algorithm to mods rustfmt#6368
- Consider using human/natural sort order style-team#143
- Use version-sorting for all sorting #115046
- rustfmt should use natural sorting rustfmt#4381
- Use versionsort for everything that's auto-reordered by name rustfmt#3764
cc @rust-lang/rustfmt @rust-lang/style @calebcartwright
Metadata
Metadata
Assignees
Labels
Area: The 2024 editionCategory: An issue tracking the progress of sth. like the implementation of an RFCStatus: This issue is ready for inclusion in the edition.Relevant to the rustfmt team, which will review and decide on the PR/issue.Relevant to the style team, which will review and decide on the PR/issue.
Activity
joshtriplett commentedon May 13, 2024
@calebcartwright @traviscross Verifying: this is labeled
T-styleandI-style-nominated, but as far as I know, this is something style already reviewed, approved, and merged into the style guide. I think this is now exclusively a matter for the rustfmt team, right?calebcartwright commentedon Aug 19, 2024
I think we answered this in a more synchronous forum like one of our t-style meetings, but for posterity, yes that's correct
chore: update toolchain (#309)
traviscross commentedon Nov 19, 2024
@rustbot labels +S-tracking-ready-for-edition -I-style-nominated
We reviewed this on the edition call. This is now ready for Rust 2024.
Thanks to @calebcartwright and the rest of the rustfmt team and style team for pushing this forward.
chore: update toolchain (#309)
chore: update toolchain (#309)