Repository navigation
rustbuild: x.py install: error: manifest path .. cargo/crates/credential/cargo-credential-1password/Cargo.toml does not exist` #110742
Description
Happened during x.py intall
Uplifting rustc (stage1 -> stage3)
Building tool cargo (stage2 -> stage3)
Finished release [optimized + debuginfo] target(s) in 0.19s
Building tool cargo-credential-1password (stage2 -> stage3)
error: manifest path `/home/matthias/vcs/github/rust_debug_assertions/src/tools/cargo/crates/credential/cargo-credential-1password/Cargo.toml` does not exist
Dist cargo-1.71.0-dev-x86_64-unknown-linux-gnu
finished in 2.199 seconds
Install cargo stage2 (Some(x86_64-unknown-linux-gnu))
install: uninstalling component 'cargo'
install: creating uninstall script at /home/matthias/.rustup/toolchains/local-debug-assertions/lib/rustlib/uninstall.sh
install: installing component 'cargo'
cargo installed.
probably since #110653 cc @weihanglo
Reacted by Weihang Lo
Activity
ehuss commentedon Apr 23, 2023
You'll need to delete the
src/tools/cargo/crates/credentialdirectory. There was probably aCargo.lockfile left behind, and git won't delete the directory automatically.matthiaskrgr commentedon Apr 23, 2023
Hm, there is no such directory ?! 😅
There is a
rust_debug_assertions/src/tools/cargo/credentialthoughweihanglo commentedon Apr 23, 2023
My fault. I forgot to update
rust/src/bootstrap/tool.rs
Line 602 in 7f94b31
Will send a PR.
matthiaskrgr commentedon Apr 23, 2023
What is most concerning to me is that this actually did not fail the entire
x.py install, so this would/did not even break CI..? is there something we can do about that?weihanglo commentedon Apr 23, 2023
Run
./x.py build cargoin CI probably?I supposed to run it locally before submitting a PR. However, that was an unlucky day. Something on nightly cannot build, so I blindly pushed 🙇🏾.
ehuss commentedon Apr 24, 2023
Oh, sorry, I misunderstood what was going on. There have been some issues with those directories being moved around, but this was different.
The issue here is that the credential helpers are being included on an "as available" basis. Because they are nightly and experimental, they were intentionally marked as being optional so that if they failed it wouldn't cause problems here on rust-lang/rust. Eventually, if it gets stabilized, this will need to change to make them required tools.
Rollup merge of rust-lang#110744 - weihanglo:cargo-credential-install…
Rollup merge of rust-lang#110744 - weihanglo:cargo-credential-install…
Rollup merge of rust-lang#110744 - weihanglo:cargo-credential-install…
Rollup merge of rust-lang#110744 - weihanglo:cargo-credential-install…