You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Tracking Issue for const ptr::drop_in_place #109342
@fee1-deadThe summary seems to link a different implementation PR Upon rereading the PR, I saw you also constified drop_in_place there - perhaps the PR title could reflect this?
With #146187 merged, the description should be updated to include the following functions added to this list:
core::ptr::drop_in_place
core::mem::ManuallyDrop::drop
core::mem::MaybeUninit::assume_init_drop
<[core::mem::MaybeUninit<_>]>::assume_init_drop
<*mut _>::drop_in_place
core::ptr::NonNull::drop_in_place
All of them are effectively wrappers over drop_in_place, so, they made sense to include in this feature flag. They also all depend on const_destruct (#133214) so that should be marked as a blocker for this as well.
It probably makes more sense to file a separate issue for that now that this feature has been implemented again. Generally, tracking issues are just for listing blockers to stabilisation, not for elaborating on specific ones, which should each have dedicated issues.
Activity
juntyr commentedon Mar 19, 2023
@fee1-dead
The summary seems to link a different implementation PRUpon rereading the PR, I saw you also constifieddrop_in_placethere - perhaps the PR title could reflect this?Rollup merge of rust-lang#146187 - clarfonthey:const-drop-in-place, r…
Rollup merge of rust-lang#146187 - clarfonthey:const-drop-in-place, r…
Rollup merge of rust-lang#146187 - clarfonthey:const-drop-in-place, r…
Rollup merge of rust-lang#146187 - clarfonthey:const-drop-in-place, r…
Unrolled build for #146187
clarfonthey commentedon Oct 15, 2025
With #146187 merged, the description should be updated to include the following functions added to this list:
core::ptr::drop_in_placecore::mem::ManuallyDrop::dropcore::mem::MaybeUninit::assume_init_drop<[core::mem::MaybeUninit<_>]>::assume_init_drop<*mut _>::drop_in_placecore::ptr::NonNull::drop_in_placeAll of them are effectively wrappers over
drop_in_place, so, they made sense to include in this feature flag. They also all depend onconst_destruct(#133214) so that should be marked as a blocker for this as well.theemathas commentedon Oct 15, 2025
Currently, drop_in_place can be called on statics in consteval, which feels a bit odd to me. See #146187 (comment)
clarfonthey commentedon Oct 15, 2025
It probably makes more sense to file a separate issue for that now that this feature has been implemented again. Generally, tracking issues are just for listing blockers to stabilisation, not for elaborating on specific ones, which should each have dedicated issues.
Rollup merge of #146187 - clarfonthey:const-drop-in-place, r=oli-obk
Rollup merge of #146187 - clarfonthey:const-drop-in-place, r=oli-obk
Rollup merge of rust-lang#146187 - clarfonthey:const-drop-in-place, r…
Rollup merge of #146187 - clarfonthey:const-drop-in-place, r=oli-obk
Rollup merge of #146187 - clarfonthey:const-drop-in-place, r=oli-obk