Make the status messages emitted by bootstrap more clear #102003

Activity

1. jyn514

   added

   T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

   E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.Call for participation: Medium difficulty. Experience needed to fix: Intermediate.

   A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to RustArea: Makes things more difficult for new or seasoned contributors to Rust

   on Sep 19, 2022
2. jyn514 commented on Sep 19, 2022

   

   jyn514

   on Sep 19, 2022

   MemberAuthor

   More actions

   This is "easy" but a lot of work; these messages are printed in a lot of different places across bootstrap and it's going to be a lot of manual work to update them all. #86022 had some WIP effort to make the status message autogenerated, but that will likely be even more work than updating the messages by hand.
3. jyn514

   self-assigned this

   on Nov 5, 2022
4. JohnTitor

   added a commit that references this issue on Nov 6, 2022

   Rollup merge of rust-lang#104078 - jyn514:dry-run-progress, r=Mark-Si…

   ...

   e35059d
5. Manishearth

   added a commit that references this issue on Nov 12, 2022

   Rollup merge of rust-lang#104078 - jyn514:dry-run-progress, r=Mark-Si…

   ...

   e744685
6. bors

   added a commit that references this issue on Nov 13, 2022

   Auto merge of rust-lang#104078 - jyn514:dry-run-progress, r=Mark-Simu…

   ...

   229e875
7. jyn514

   removed their assignment

   on Dec 20, 2022
8. jyn514 commented on Dec 20, 2022

   

   jyn514

   on Dec 20, 2022

   MemberAuthor

   More actions

   An example change:

   diff --git a/src/bootstrap/tool.rs b/src/bootstrap/tool.rs
   index 24b033cc0dc..b8ea072e584 100644
   --- a/src/bootstrap/tool.rs
   +++ b/src/bootstrap/tool.rs
   @@ -70,7 +70,17 @@ fn run(self, builder: &Builder<'_>) -> Option<PathBuf> {
                &self.extra_features,
            );
    
   -        builder.info(&format!("Building stage{} tool {} ({})", compiler.stage, tool, target));
   +        let msg = if self.mode == Mode::ToolRustc {
   +            format!(
   +                "Building stage {} tool {tool} using stage {} sysroot ({target})",
   +                compiler.stage + 1,
   +                compiler.stage
   +            )
   +        } else {
   +            format!("Building tool {tool} using stage {} sysroot ({target})", compiler.stage)
   +        };
   +        builder.info(&msg);
   +
            let mut duplicates = Vec::new();
            let is_expected = compile::stream_cargo(builder, cargo, vec![], &mut |msg| {
                // Only care about big things like the RLS/Cargo for now
9. jyn514 commented on Apr 29, 2023

   

   jyn514

   on Apr 29, 2023

   MemberAuthor

   More actions

   fixed in #108171 (lol apparently i opened the same issue twice)
10. jyn514

    closed this as completedon Apr 29, 2023