Repository navigation
ci: Resolve most zizmor findings as of [email protected] - #1410
Open
hashcatHitman wants to merge 4 commits into
Open
hashcatHitman wants to merge 4 commits into
hashcatHitman wants to merge 4 commits into
Conversation
See: https://github.com/actions/checkout/releases/tag/v5.1.0 This is the same version we're already implicitly using. Signed-off-by: hashcatHitman <[email protected]>
Because `dtolnay/rust-toolchain` doesn't provide proper releases, it is impossible to pin correctly. It also isn't really necessary, since all standard GitHub Actions runners have `rustup` preinstalled. Signed-off-by: hashcatHitman <[email protected]>
Signed-off-by: hashcatHitman <[email protected]>
Signed-off-by: hashcatHitman <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In pursuit of getting more
zizmorlints enforced acrossrust-langrepos throughcrabwatch, this PR fixes mostzizmorfindings as of[email protected], using theauditorpersona. The lints that actually fired per-persona level are:regularpersona findings:artipackedunpinned-usespedanticpersona findings:regularsuperfluous-actionstemplate-injectionanonymous-definition(Because coming up with names is hard and there is minimal benefit to this)concurrency-limits(Due to concerns about special cases. See also: Determine special cases forconcurrency-limitscrabwatch#107)auditorpersona findings:pedanticThe hash pin format is supported by tools like Dependabot and Renovate, which can update the pinned hashes and their associated comments. If you'd like help setting either of those up, let me know which you prefer, and if you'd like it in this PR or a new one. By default, I'd assume to set it up to only update GitHub Actions.