Repository navigation
fix(libz-sys): stop printing zlib cmd in build script - #280
Merged
Merged
Conversation
The env vars may be captured by Cargo in fingerprint and leaked, similar to the miri case, see: https://blog.rust-lang.org/2026/09/21/github-actions-leaking-secrets-when-miri-output-is-cached/
weihanglo
changed the title
Byron
approved these changes
Oct 28, 2026
Byron
left a comment
Byron
left a comment
Member
There was a problem hiding this comment.
Thanks, a release will be available shortly.
4 tasks done
5 tasks done
opensource-fork-sync Bot
pushed a commit
to cla7aye15I4nd/opensource-tempoxyz__tempo
that referenced
this pull request
Oct 29, 2026
Bumps `libz-sys` 1.1.29 → 1.1.31 (lockfile only) to fix RUSTSEC-2026-0418, which fails `cargo deny` on every PR. Older build scripts print the build environment, secrets included. Audited the crate diff: `src/` (vendored zlib) is unchanged. `build.rs` drops the `println!` that leaked the environment ([rust-lang/libz-sys#280](rust-lang/libz-sys#280)), uses `Z_SOLO` only on `wasm32-unknown-unknown`, and adds `-march=armv8-a+crc` on aarch64 when the target has `crc`. Published by a crate owner (Byron) from upstream commit 595fbb7. `cargo deny check` passes locally.
This was referenced Oct 29, 2026
This was referenced Oct 29, 2026
This was referenced Oct 30, 2026
jxom
pushed a commit
to tempoxyz/tempo
that referenced
this pull request
Nov 2, 2026
Bumps `libz-sys` 1.1.29 → 1.1.31 (lockfile only) to fix RUSTSEC-2026-0418, which fails `cargo deny` on every PR. Older build scripts print the build environment, secrets included. Audited the crate diff: `src/` (vendored zlib) is unchanged. `build.rs` drops the `println!` that leaked the environment ([rust-lang/libz-sys#280](rust-lang/libz-sys#280)), uses `Z_SOLO` only on `wasm32-unknown-unknown`, and adds `-march=armv8-a+crc` on aarch64 when the target has `crc`. Published by a crate owner (Byron) from upstream commit 595fbb7. `cargo deny check` passes locally. (cherry picked from commit 2e4a4d1)
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The env vars may be captured by Cargo in fingerprint and leaked, similar to the miri case, see: https://blog.rust-lang.org/2026/09/21/github-actions-leaking-secrets-when-miri-output-is-cached/
cc @Byron
would appreciate if we can get a patch release.