Skip to content

add span around aqcuiring db connections - #3655

Merged
syphar merged 4 commits into
rust-lang:mainfrom
syphar:tracing
Oct 30, 2026
Merged

syphar merged 4 commits into
rust-lang:mainfrom
syphar:tracing

Conversation

@syphar

@syphar syphar commented Oct 30, 2026

Copy link
Copy Markdown
Member

in certain load situations I saw:

image

where we seem to spend time in something that is not tracked in spans. My initial guess it the db connection pool.

So now we get:

  • a span around Pool.get_async
  • a small optimization in the source browser that frees the db connection earlier. might be a fix.
  • a metric to track connection pool acquire duration

@syphar syphar self-assigned this Oct 30, 2026
@syphar
syphar marked this pull request as ready for review October 30, 2026 20:00
@syphar
syphar requested a review from a team as a code owner October 30, 2026 20:00
@github-actions github-actions Bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Oct 30, 2026
@syphar

syphar commented Oct 30, 2026

Copy link
Copy Markdown
Member Author

r? @GuillaumeGomez

@rustbot rustbot assigned GuillaumeGomez and unassigned syphar Oct 30, 2026
@syphar

syphar commented Oct 30, 2026

Copy link
Copy Markdown
Member Author

short update:
the problem really was the connection pool:
image

since I increased max_connections in postgres two weeks ago, I just increased pool size and that helped.

The changes in this PR are still useful.

@syphar

syphar commented Oct 30, 2026

Copy link
Copy Markdown
Member Author

pool is full again:
image

@syphar
syphar merged commit b08ae31 into rust-lang:main Oct 30, 2026
11 of 12 checks passed
@syphar
syphar deleted the tracing branch October 30, 2026 23:30
@github-actions github-actions Bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Oct 30, 2026
@syphar

syphar commented Oct 30, 2026

Copy link
Copy Markdown
Member Author

( merged so I can solve / evaluate the production issuse)

@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Nov 2, 2026

This branch was previously deployed

1 inactive deployment
github-pages — 92703e56 Deployed Oct 30, 2026 by syphar via deploy #853
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants