Repository navigation
repository stats: reduce memory usage in regular stats update - #3653
Merged
Merged
Conversation
github-actions
Bot
added
the
S-waiting-on-review
syphar
force-pushed
the
repo-stats-batch
branch
from
October 30, 2026 11:35
c949181 to
a99983f
Compare
syphar
marked this pull request as ready for review
October 30, 2026 11:36
GuillaumeGomez
approved these changes
Oct 30, 2026
github-actions
Bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can stream the query result and directly batch it, no need to store everything in advance.
Also, use a db transaction to make the updates faster. Only one commit in the db is faster than one per query. We can optimize this even further by creating a single sql statement for all deletes & all updates, but not for now.
Not a problem yet, but I saw it and wanted to fix it before I forget.