Skip to content

nannou crate build failed #471

Closed
Closed

Description

@mitchmindtree

Crate name: nannou
Build failure link: https://docs.rs/crate/nannou/0.12.0/builds/196525

Additional details:
The build seems to fail on the xcb dependency version 0.8.2, however this build has succeeded in the past and is currently available on docs.rs. This leads me to wonder if the cause is a bug in the latest rustdoc nightly. Is it possible to get the documentation re-built with stable?

Activity

  1. jyn514 commented on Nov 8, 2019

    @jyn514
    Member

    Related: #229, #228

  2. jyn514 commented on Nov 8, 2019

    @jyn514
    Member

    Your build error doesn't seem to be related to the version of rust, though. cc @pietroalbini, do you intentionally make /opt/rustwide/cargo-home read-only?

  3. jyn514 commented on Nov 8, 2019

    @jyn514
    Member

    It looks like xcb is a new dependency in nannou 0.12, I wonder if it's trying to write to part of the filesystem it's not supposed to. I know we changed the sandboxing pretty significantly about a month ago in the switch to rustwide: #407, xcb hasn't been rebuilt since 2018: https://docs.rs/crate/xcb/0.8.2/builds/87332

  4. emilyalbini commented on Nov 10, 2019

    @emilyalbini
    Member

    Your build error doesn't seem to be related to the version of rust, though. cc @pietroalbini, do you intentionally make /opt/rustwide/cargo-home read-only?

    Yeah, otherwise a malicious crate could've messed up the state for other crates.

  5. alberdingk-thijm commented on Nov 21, 2019

    @alberdingk-thijm

    It looks like xcb is a new dependency in nannou 0.12, I wonder if it's trying to write to part of the filesystem it's not supposed to. I know we changed the sandboxing pretty significantly about a month ago in the switch to rustwide: #407, xcb hasn't been rebuilt since 2018: https://docs.rs/crate/xcb/0.8.2/builds/87332

    I just tried building xcb 0.8.2 myself using docker-compose run web build crate xcb 0.8.2, and this appears to be what caused the problem.
    The crate has a python script rs_client.py which it uses to create some FFI files. The exact line it fails at is rs_client.py:114.

    The good news is, xcb 0.9.0 works fine, so I think if x11-clipboard (the dependency of copypasta, the dependency of conrod_core, the dependency of nannou) upgrades to 0.9.0, this should be fixed.

  6. jyn514 commented on Nov 21, 2019

    @jyn514
    Member

    Looks like this isn't a bug in docs.rs, going to close this.

  7. mitchmindtree commented on Nov 23, 2019

    @mitchmindtree
    Author

    Thanks for digging into this @alberdingk-thijm!

  8. alberdingk-thijm commented on Dec 4, 2019

    @alberdingk-thijm

    Looks like this isn't a bug in docs.rs, going to close this.

    @jyn514, do you happen to know when docs.rs will try to build nannou (and the other crates related to this error in xcb) again?

  9. jyn514 commented on Dec 5, 2019

    @jyn514
    Member

    Rebuilding automagically is #464 . Currently someone has to schedule a manual build.

  10. jyn514 commented on Dec 5, 2019

    @jyn514
    Member

    This particular crate won't be helped by rebuilding however because it tries to write to a read only filesystem.

  11. alberdingk-thijm commented on Dec 5, 2019

    @alberdingk-thijm

    We tracked down the dependency (x11-clipboard) that caused the error and sent a PR quininer/x11-clipboard#17 through, which has been bubbled up to the other dependency copypasta in a minor patch alacritty/alacritty#3024. conrod_core (the dependency which pulls in copypasta) just requests 0.6, so I would think building with copypasta 0.6.1 would get rid of this issue, although admittedly I can't seem to figure out how to tell the docker container to do that on my own machine.

  12. jyn514 commented on Dec 5, 2019

    @jyn514
    Member

    @alberdingk-thijm Could you make these updates in a different repo, such as nannou-org/nannou#429? This is not a docs.rs bug.

  13. jyn514 commented on Dec 5, 2019

    @jyn514
    Member

    Oh hold on I think I misunderstood your comment. You're asking us to build with a different version of a minor dependency? We don't control dependency management, that's done by cargo. If you've fixed the bug you can publish a new version and docs.rs will build that version.

  14. alberdingk-thijm commented on Dec 5, 2019

    @alberdingk-thijm

    Oh hold on I think I misunderstood your comment. You're asking us to build with a different version of a minor dependency? We don't control dependency management, that's done by cargo. If you've fixed the bug you can publish a new version and docs.rs will build that version.

    Gotcha, that's what I was asking. Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-build-failureCategory: This is a crate that failed to build

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions