Skip to content

Allow uncommon_codepoints in confusable test - #17676

Merged
weihanglo merged 1 commit into
rust-lang:masterfrom
clubby789:unicode-18
Nov 3, 2026
Merged

weihanglo merged 1 commit into
rust-lang:masterfrom
clubby789:unicode-18

Conversation

@clubby789

Copy link
Copy Markdown
Contributor

rust-lang/rust#165289 updates the Unicode version used by the lexer to 18, which includes a new set of characters firing uncommon_codepoints. Allow this in a test to prevent failures there.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 2, 2026
@rustbot

rustbot commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @Muscraft, @epage, @weihanglo
  • @Muscraft, @epage, @weihanglo expanded to Muscraft, epage, weihanglo
  • Random selection from Muscraft, epage, weihanglo

/// ```
pub fn f() {}
pub const Ě: i32 = 1;
pub const Ĕ: i32 = 2;

@clubby789 clubby789 Nov 2, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

---- expected: tests/testsuite/lints_table.rs:731:27
++++ actual:   stderr
   1    1 | [CHECKING] foo v0.0.1 ([ROOT]/foo)
        2 + [WARNING] identifier contains an uncommon character: 'Ĕ'
        3 +   --> src/lib.rs:12:11
        4 +    |
        5 + 12 | pub const Ĕ: i32 = 2;
        6 +    |           ^
        7 +    |
        8 +    = [NOTE] this character is included in the Unicode general security profile
        9 +    = [NOTE] `#[warn(uncommon_codepoints)]` on by default
       10 + 
       11 + [WARNING] `foo` (lib) generated 1 warning

View changes since the review

@weihanglo weihanglo left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rustbot
rustbot enabled auto-merge November 2, 2026 19:17
auto-merge was automatically disabled November 2, 2026 22:01

Head branch was pushed to by a user without write access

@clubby789

clubby789 commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor Author

Pushed to retrigger as CI broke due to network issue

Edit: Ah

@weihanglo

Copy link
Copy Markdown
Member

Yeah probably need to wait and rebase.

@rustbot

rustbot commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@weihanglo
weihanglo enabled auto-merge November 2, 2026 23:57
@weihanglo
weihanglo added this pull request to the merge queue Nov 3, 2026
Merged via the queue into rust-lang:master with commit 2be5575 Nov 3, 2026
30 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 3, 2026
rust-bors Bot pushed a commit to rust-lang/rust that referenced this pull request Nov 4, 2026
Update cargo submodule

13 commits in 31d3246e0e8d3a80d4a90b54aa48ff180adb408b..3c747ea3ead23951c1b43a5edfcbdb449135ddeb
2026-10-27 13:54:39 +0000 to 2026-11-03 21:25:31 +0000
- Link to `cargo search` result's crates.io pages (rust-lang/cargo#17668)
- Clean `/out` dir before compilation  (rust-lang/cargo#17675)
- Allow `uncommon_codepoints` in confusable test (rust-lang/cargo#17676)
- test: Update https certificate failed messages (rust-lang/cargo#17679)
- chore(deps): update rust-lang/crates-io-auth-action action to v1.0.6 (rust-lang/cargo#17670)
- chore(deps): update actions/deploy-pages action to v5.0.1 (rust-lang/cargo#17669)
- Fix manifest schema generation: `TomlOptLevel` and `StringOrVec` (rust-lang/cargo#17660)
- remove deprecated tempdir (rust-lang/cargo#17663)
- chore(ci): remove Windows rustup PATH workaround (rust-lang/cargo#17667)
- test: probe stable cargo through rustup (rust-lang/cargo#17666)
- Update outdated registry function comments (rust-lang/cargo#17664)
- perf(windows): Delay-load system DLLs that most commands don't use (rust-lang/cargo#17623)
- Suppress `dead_code_pub_in_binary` for library test units (rust-lang/cargo#17608)
@rustbot rustbot added this to the 1.101.0 milestone Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants