Repository navigation
Remove nomem from asm intrinsics. - #236
Merged
Merged
Conversation
jonathanpallant
changed the title
nomem ]]`from asm intrinsics.nomem from asm intrinsics.
jonathanpallant
force-pushed
the
remove-nomem
branch
from
October 18, 2026 16:28
a587e20 to
ca14df9
Compare
They generally should be treated like memory operations in terms of their observability and their ability to be moved. Adds fences either side of the IRQ operations, to ensure we don't do the IRQ disable before checking if IRQs are disabled. Fixes #234
jonathanpallant
force-pushed
the
remove-nomem
branch
from
October 18, 2026 16:38
dd6c370 to
b365d37
Compare
adamgreig
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They generally should be treated like memory operations in terms of their observability and their ability to be moved.
Adds fences either side of the IRQ operations, to ensure we don't do the IRQ disable before checking if IRQs are disabled.
Fixes #234