Repository navigation
fix(progress): Detect Ghostty through TERM over SSH - #371
Merged
Merged
Conversation
dbast
changed the title
epage
reviewed
Nov 4, 2026
Recognize TERM=xterm-ghostty alongside TERM_PROGRAM=ghostty. Observed in a Ghostty SSH session: stderr was a TTY and TERM was xterm-ghostty, but TERM_PROGRAM was absent because the server did not accept environment forwarding (default for OpenSSH). Progress detection therefore returned false despite the terminal supporting OSC 9;4. SSH sends TERM when requesting a PTY without requiring AcceptEnv. This fallback enables detection in that setup without SSH server configuration changes. The existing TTY gate remains unchanged; generic xterm values are not treated as supporting progress. The same exact TERM fallback is also used here: https://github.com/MoonshotAI/kimi-code/blob/main/apps/kimi-code/src/tui/utils/terminal-notification.ts References: https://ghostty.org/docs/help/terminfo https://ghostty.org/docs/install/release-notes/1-2-0#graphical-progress-bars
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to solve?
Recognize TERM=xterm-ghostty alongside TERM_PROGRAM=ghostty.
Observed in a Ghostty SSH session: stderr was a TTY and TERM was xterm-ghostty, but TERM_PROGRAM was absent because the server did not accept environment forwarding (default for OpenSSH). Progress detection therefore returned false despite the terminal supporting OSC 9;4.
SSH sends TERM when requesting a PTY without requiring AcceptEnv. This fallback enables detection in that setup without SSH server configuration changes. The existing TTY gate remains unchanged; generic xterm values are not treated as supporting progress.
Adds also isolated regression tests for the fallback, exact matching, and non-TTY exclusion.
The same exact TERM fallback is also used here:
https://github.com/MoonshotAI/kimi-code/blob/main/apps/kimi-code/src/tui/utils/terminal-notification.ts
References:
https://ghostty.org/docs/help/terminfo
https://ghostty.org/docs/install/release-notes/1-2-0#graphical-progress-bars
Notes to reviewers
LLM involvement: No. Figured out terminal env variables with and without ssh and then composed the conditional + test + context description.