Make trivia first class member of token - #219
Merged
ChayimFriedman2 merged 9 commits intoSep 7, 2026
Merged
Conversation
ChayimFriedman2
requested changes
Aug 16, 2026
bit-aloo
force-pushed
the
2026-08-14-trivia-first-class
branch
4 times, most recently
from
August 31, 2026 01:48
9f6a8a3 to
fd291b6
Compare
bit-aloo
marked this pull request as ready for review
August 31, 2026 01:54
ChayimFriedman2
requested changes
Aug 31, 2026
ChayimFriedman2
left a comment
ChayimFriedman2
left a comment
Contributor
There was a problem hiding this comment.
Hope it won't be too hard for you to change r-a 🫢️
bit-aloo
force-pushed
the
2026-08-14-trivia-first-class
branch
2 times, most recently
from
September 1, 2026 19:25
edf8934 to
38a85fd
Compare
ChayimFriedman2
requested changes
Sep 1, 2026
bit-aloo
force-pushed
the
2026-08-14-trivia-first-class
branch
from
September 4, 2026 10:18
8991744 to
8240204
Compare
ChayimFriedman2
approved these changes
Sep 7, 2026
ChayimFriedman2
left a comment
ChayimFriedman2
left a comment
Contributor
There was a problem hiding this comment.
Thanks!
I'm merging this but not releasing yet because we might want to make more adjustments to shrink the diff of the r-a PR, for example not printing trivia when empty like I said.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still making changes to RA