[RUN-4693] rejectUndeclaredOptions defaults to false (opt-in) - #1962
Closed
ronaveva wants to merge 1 commit into
Closed
[RUN-4693] rejectUndeclaredOptions defaults to false (opt-in)#1962ronaveva wants to merge 1 commit into
ronaveva wants to merge 1 commit into
Conversation
The undeclared-option reject control now defaults to off (product change): update the config reference and the job-options page so they describe it as opt-in (default false), remove the "default true"/"warns at startup when false" wording, and note that the retry/jobref scope details apply only when the control is enabled. Co-Authored-By: Claude Opus 4.8 <[email protected]>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are limited to documentation and consistently align the described defaults/behavior with the stated product change.
Pull request overview
Updates the Rundeck documentation to reflect the product change that makes rundeck.execution.rejectUndeclaredOptions default to false (opt-in), ensuring the option-injection guidance matches current runtime behavior.
Changes:
- Updates the config reference to show the property default as
falseand reframes the behavior as opt-in. - Removes the previously documented “startup security warning” note and clarifies scope phrasing to apply when enabled.
- Adjusts the Jobs manual “Reject undeclared options” guidance to instruct explicitly setting
...=trueto enforce rejection.
File summaries
| File | Description |
|---|---|
| docs/manual/jobs/job-options.md | Updates the “Reject undeclared options” bullet to describe opt-in behavior and the required =true setting. |
| docs/administration/configuration/config-file-reference.md | Flips the documented default to false, removes outdated startup-warning language, and clarifies when the scope details apply. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ronaveva
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follows the product change (rundeck/rundeck#10568) that flips
rundeck.execution.rejectUndeclaredOptionsto defaultfalse(opt-in).Updates the docs merged earlier (from #1946) so they no longer describe the control as on-by-default:
docs/administration/configuration/config-file-reference.md— property defaulttrue→false; reworded to "opt-in, off by default"; removed the "logs a security warning at startup when false" note (that startup warning was removed with the default flip); the retry/jobrefscope details now say they apply "when enabled".docs/manual/jobs/job-options.md— the "Reject undeclared options" bullet now describes it as opt-in (=trueto reject).🤖 Generated with Claude Code