fix(rse): wrap long protocol prefixes instead of truncating them - #821
Open
Vrohs wants to merge 3 commits into
Open
fix(rse): wrap long protocol prefixes instead of truncating them#821Vrohs wants to merge 3 commits into
Vrohs wants to merge 3 commits into
Conversation
5 tasks
Vrohs
force-pushed
the
fix-647-rse-prefix-column-width
branch
from
September 1, 2026 05:45
442c201 to
d571541
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this PR, I confirm I have followed the Contributing Guide.
Description
The
prefixcolumn on the RSE details protocols table is set towidth: 200, flex: 0, so it never responds to viewport width. After padding that leaves ~170px of text, and 5 of the 6 prefixes in the repository's own fixtures are truncated at both 1280px and 1920px.Widening it enough for the longest paths needs roughly
minWidth: 460, which pushes the table's minimum width from ~1390px to ~1650px and starts horizontal scrolling on more screens, against the "no horizontal scrolling introduced unnecessarily" criterion in the issue. This wraps instead:minWidth: 300, flex: 1, wrapText, autoHeight.Measured in Chromium, before and after:
scrollWidthis unchanged, so no extra horizontal scrolling is introduced. Row height only grows where a value needs a second line: one row at 1280px, none at 1920px. Column drag-resizing was already enabled throughRegularTable'sdefaultColDef.The column definitions are lifted into
getProtocolColumnDefs()so the sizing can be asserted without rendering the grid, since ag-grid renders no grid DOM under jsdom. It is a factory rather than a shared constant so each table instance still builds its own definitions, as the inline literal did. The first commit is that extraction on its own, with no behaviour change; reviewingDetailsRSEProtocolsTable.tsxwithgit diff -whides the re-indentation and leaves 14 added / 8 removed lines.Checklist
in the description and the commit follows conventional commits
Notes for contributors
the Contributing Guide): use
Closes: #____on the commit that resolvesthe issue, and
Issue: #____on intermediate commits or if the issueshould remain open.
appropriate for the touched components; otherwise leave it empty and one
will be assigned.
closed promptly.
Additional notes for reviewer
Note: This OPTIONAL section is only relevant for the REVIEWER, please leave it in the PR
Reviewer template
Reviewers should copy&paste the code-block below and fill it out for APPROVED pull requests. If the PR does not meet the standards the project sets out, the reasons should be WELL EXPLAINED in a CHANGE REQUEST (The answers below do not need to be answered in that case)