Skip to content

fix(rse): wrap long protocol prefixes instead of truncating them - #821

Open
Vrohs wants to merge 3 commits into
rucio:mainfrom
Vrohs:fix-647-rse-prefix-column-width
Open

fix(rse): wrap long protocol prefixes instead of truncating them#821
Vrohs wants to merge 3 commits into
rucio:mainfrom
Vrohs:fix-647-rse-prefix-column-width

Conversation

@Vrohs

@Vrohs Vrohs commented Aug 28, 2026

Copy link
Copy Markdown

By submitting this PR, I confirm I have followed the Contributing Guide.

Description

The prefix column on the RSE details protocols table is set to width: 200, flex: 0, so it never responds to viewport width. After padding that leaves ~170px of text, and 5 of the 6 prefixes in the repository's own fixtures are truncated at both 1280px and 1920px.

Widening it enough for the longest paths needs roughly minWidth: 460, which pushes the table's minimum width from ~1390px to ~1650px and starts horizontal scrolling on more screens, against the "no horizontal scrolling introduced unnecessarily" criterion in the issue. This wraps instead: minWidth: 300, flex: 1, wrapText, autoHeight.

Measured in Chromium, before and after:

@1280 @1920 grid scrollWidth @1280
before 5 of 6 truncated 5 of 6 truncated 1370
after all visible all visible 1370

scrollWidth is unchanged, so no extra horizontal scrolling is introduced. Row height only grows where a value needs a second line: one row at 1280px, none at 1920px. Column drag-resizing was already enabled through RegularTable's defaultColDef.

The column definitions are lifted into getProtocolColumnDefs() so the sizing can be asserted without rendering the grid, since ag-grid renders no grid DOM under jsdom. It is a factory rather than a shared constant so each table instance still builds its own definitions, as the inline literal did. The first commit is that extraction on its own, with no behaviour change; reviewing DetailsRSEProtocolsTable.tsx with git diff -w hides the re-indentation and leaves 14 added / 8 removed lines.

Checklist

  • This PR closes Increase RSE prefix column width for full visibility #647
  • Tests cover the change, or no tests are needed
  • Documentation is updated (link the docs PR here), or no documentation change is needed
  • Database migrations are included, or the change touches no database schema
  • This PR contains no breaking changes, or the breaking change is described
    in the description and the commit follows conventional commits

Notes for contributors

  • Commit trailers: Please also link the issue in the commit message (see
    the Contributing Guide): use Closes: #____ on the commit that resolves
    the issue, and Issue: #____ on intermediate commits or if the issue
    should remain open.
  • Reviewer: After submitting, assign a reviewer if you know who is
    appropriate for the touched components; otherwise leave it empty and one
    will be assigned.
  • Stale PRs: PRs with failing tests or an unresponsive author will be
    closed promptly.

Additional notes for reviewer

Note: This OPTIONAL section is only relevant for the REVIEWER, please leave it in the PR

Reviewer template Reviewers should copy&paste the code-block below and fill it out for APPROVED pull requests. If the PR does not meet the standards the project sets out, the reasons should be WELL EXPLAINED in a CHANGE REQUEST (The answers below do not need to be answered in that case)
  • Confidence in review: I am confident in my review concerning the components this PR touches: [High 🟢, Medium 🟡 Low 🔴]
  • Confidence in scope: I am confident that this fits into the scope of the project and should be included: [High 🟢, Medium 🟡, Low 🔴]
    • For Medium and Low, explain in notes why this should be included
  • Quality: The approach is sound, maintainable and addresses the issue in the best way: [Agree 🟢]
  • Security: This PR does NOT require increased attention in terms of security (E.g. new dependencies): [Agree 🟢, Disagree 🔴]
    • If Disagree explain in notes.
  • Backwards compatibility: This PR does NOT introduce backwards compatibility breaking changes: [Agree 🟢, Disagree 🔴]
    • If Disagree explain in notes
  • Testing: This PR is well tested: [Agree 🟢]
  • Documentation: Relevant documentation or comments are updated or not required: [Agree 🟢]
- **Confidence in review**: High 🟢 Medium 🟡 Low 🔴
- **Confidence in scope**: High 🟢 Medium 🟡 Low 🔴
- **Quality**: Agree 🟢
- **Security**: Agree 🟢 Disagree 🔴
- **Backwards compatibility**: Agree 🟢 Disagree 🔴
- **Testing**: Agree 🟢
- **Documentation**: Agree 🟢

# Notes for merger



@Vrohs
Vrohs force-pushed the fix-647-rse-prefix-column-width branch from 442c201 to d571541 Compare September 1, 2026 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increase RSE prefix column width for full visibility

1 participant