Repository navigation
solid_queue: type ActiveJob::BatchId#serialize - #1110
Merged
github-actions[bot] merged 1 commit intoOct 21, 2026
Merged
Conversation
solid_queue 1.7 includes ActiveJob::BatchId into ActiveJob::Base, and its serialize override returns super, the Hash ActiveJob::Core#serialize builds. Without a signature, tools that see the include type ActiveJob::Base#serialize as untyped. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01SEntZKsZwQHhzqcwG7MTqn
apiology
marked this pull request as ready for review
October 21, 2026 18:32
|
@apiology Thanks for your contribution! Please follow the instructions below for each change. Available commandsYou can use the following commands by commenting on this PR.
|
Contributor
Author
|
/merge |
apiology
added a commit
to iftheshoefritz/solargraph-rails
that referenced
this pull request
Oct 21, 2026
solid_queue 1.7 includes ActiveJob::BatchId into ActiveJob::Base, and its untyped #serialize shadows ActiveJob::Core#serialize, so ActiveJob::Base#serialize resolves to undefined on Rails 8. ruby/gem_rbs_collection#1110 adds gems/solid_queue/1.7, typing BatchId#serialize as Hash[String, untyped]. Pin the collection to its merge commit so ActiveJob::Base#serialize resolves to Hash{String => undefined} again. Claude-Session: https://claude.ai/code/session_01SEntZKsZwQHhzqcwG7MTqn Co-authored-by: Claude Opus 5.5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude: This PR was written by Claude Code on behalf of @apiology.
Problem
solid_queue 1.7 includes
ActiveJob::BatchIdintoActiveJob::Base, and itsserializeoverride has no signature, so tools reading this collection loseActiveJob::Core#serialize's type for every job:Solution
Add
gems/solid_queue/1.7declaringActiveJob::BatchId#serializewithActiveJob::Core#serialize's type,() -> ::Hash[::String, untyped], with a test.