Repository navigation
Conversation
Builders::Default#value(token) returns token[0], the value half of a [value, range] token pair. Subclasses of the default builder call it, so type it generically over the value. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01GgkyXKEZWpEFXo6ceA5MSw
string_value(token) returns the String half of a token pair. loc(token) returns the Range half, or nil when the token or its value is nil. Both are private helpers that builder subclasses call. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01GgkyXKEZWpEFXo6ceA5MSw
The lexer builds every token as [value, range(s, e)], so a token's second element is always a Parser::Source::Range. Replace the untyped slots in value, string_value and loc, and pass a real range in the tests. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01GgkyXKEZWpEFXo6ceA5MSw
apiology
marked this pull request as ready for review
October 16, 2026 22:12
|
@apiology Thanks for your contribution! Please follow the instructions below for each change. Available commandsYou can use the following commands by commenting on this PR.
|
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Claude: This PR was written by Claude Code on behalf of @apiology.
Problem:
A
Parser::Builders::Defaultsubclass getsuntypedback fromvalue, and cannot callstring_valueorloc:The parser RBS has no
Builders::Defaultsignatures, so every builder subclass loses the token's type.Solution:
Add private
value: [T] ([T, Source::Range] token) -> T,string_value: ([String, Source::Range] token) -> Stringandloc: ([top, Source::Range]? token) -> Source::Range?, matchingvalue,string_valueandlocin parser v3.3.12.0.