Repository navigation
feat(msgpack): Add types for v1.8 - #1102
Merged
Merged
Conversation
Cover the basic API: MessagePack.pack/unpack, #to_msgpack on core classes, Packer, Unpacker, Factory (including Pool and register_type), Timestamp, and the unpack error classes. Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
@ksss Thanks for your contribution! Please follow the instructions below for each change. Available commandsYou can use the following commands by commenting on this PR.
|
Collaborator
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add RBS for the basic API of msgpack v1.8.
Covered API
MessagePack.pack/dumpandMessagePack.unpack/load#to_msgpackon core classes (NilClass,TrueClass,FalseClass,Integer,Float,String,Symbol,Array,Hash) throughMessagePack::CoreExtMessagePack::PackerandMessagePack::Unpacker(streaming API,register_type)MessagePack::Factory, includingregister_typeoptions andFactory::PoolMessagePack::Timestamp,MessagePack::Time::Packer/Unpacker,MessagePack::ExtensionValueUnpackError,MalformedFormatError, ...)Packer#full_packreturnsString?because it returnsnilwhen the packer writes to an IO.The tests are based on the README examples.
🤖 Generated with Claude Code