Repository navigation
rubocop: add RuboCop::Options#parse signature - #1099
Merged
Merged
Conversation
Callers that run RuboCop in-process, such as Solargraph, call RuboCop::Options.new.parse(args) and destructure the result into an options hash and a path list. Without a signature the result is untyped. Options#parse returns [@options, args], where @options is a Symbol-keyed hash whose values vary by option. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01GgkyXKEZWpEFXo6ceA5MSw
apiology
added a commit
to apiology/solargraph
that referenced
this pull request
Oct 15, 2026
The rubocop 1.57 RBS in gem_rbs_collection has no RuboCop::Options, so parse's result was untyped and options[:stdin] was an unresolved call. Add an RBS fill citing ruby/gem_rbs_collection#1099, which adds the same signature upstream, and drop the three markers it clears. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01GgkyXKEZWpEFXo6ceA5MSw
apiology
marked this pull request as ready for review
October 19, 2026 20:02
|
@apiology Thanks for your contribution! Please follow the instructions below for each change. Available commandsYou can use the following commands by commenting on this PR.
|
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude: With this change,
options, paths = RuboCop::Options.new.parse(args)type-checks withoptionsasHash[Symbol, untyped]andpathsasArray[String]. Before it, the rubocop 1.57 RBS had noRuboCop::Options, so the result was untyped. Solargraph uses this call to run RuboCop in-process: it destructures the result and reads and writesoptions[:stdin].In
lib/rubocop/options.rb, both v1.57.0 and master return[@options, args]fromparse.@optionsis a Symbol-keyed hash whose value types depend on the option; for example,parsereplaces:stdinwith the file contents. So the values areuntyped.Options#initializetakes no arguments, so it needs no signature. RuboCop marksOptionsas@api private, but tools that embed RuboCop call it.The test destructures the result, assigns
options[:stdin], callsoptions.key?and usespaths.first.bin/test gems/rubocop/1.57passes: no type errors and no untyped calls.🤖 Generated with Claude Code