[apiology]

Claude: This PR was written by Claude Code on behalf of @apiology.

Problem:

Rails documents authenticate_with_http_token as: "Returns the return value of login_procedure if a token is found. Returns nil if no token is found." The RBS declares the block and the method as -> boolish, so the documented pattern loses the user's type:

class AuthController < ActionController::Base
  def show
    authenticate_with_http_token { |token, options| token.length + options.size }&.succ
  end
end

[error] Type `top` does not have method `succ`
│ Diagnostic ID: Ruby::NoMethod

The Basic and Digest controller methods are all untyped in actionpack-generated.rbs, and in 7.2 their blocks receive no parameters.

Solution: In 7.2 and 8.1, hand-type Token, Basic and Digest in actioncontroller.rbs, removing the matching generated declarations as 8.1 already does for Token:

• Token and Basic make the block's return a type parameter, like Thread::Mutex#synchronize: authenticate_with_* returns T?, and the or-request forms return T | String.
• The request_*_authentication methods return String, since they end in render.
• Basic's name and password and Digest's username are String?, because Rails passes nil for a malformed header.

Tests in 7.2/_test and 8.1/_test fail before this change and pass after.

References: http_authentication.rb v8.1.4, rendering.rb v8.1.4

🤖 Generated with Claude Code

https://claude.ai/code/session_01EhUSLUimEYJyCZv8NdQGKb

[github-actions]

@apiology Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

• /merge: Merge this PR if CI passes

---

actionpack

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@ksss, @tk0miya, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.

[ksss]

APPROVE

[github-actions]

Thanks for your review, @ksss!

@apiology, @ksss This PR is ready to be merged.
Just comment /merge to merge this PR.

[apiology]

/merge