Ignore quotes when detecting the row separator - #365
Open
gaoflow wants to merge 1 commit into
Open
Conversation
`:auto` row separator detection scanned the sample for the first CR/LF without tracking quote state, so a CR inside a quoted field was mistaken for the row separator. As a result CSV could not parse its own output: `CSV.parse(CSV.generate)` corrupted or crashed on any field containing a carriage return. For example `["a\rb", "x"]` round-tripped to `["a\rb", "x\n"]`, and fields with `\r\n` or a lone `\r` raised CSV::MalformedCSVError. Make detection skip CR/LF that fall inside a quoted field. Unquoted CR is still honored as a separator, so old Mac line endings keep working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:autorow-separator detection scans the sample for the first CR/LF without tracking quote state, so a CR inside a quoted field is mistaken for the row separator. CSV therefore cannot parse its owngenerateoutput whenever a field contains\r:All three parse correctly with an explicit
row_sep: "\n", which isolates the fault to:autodetection.detect_row_separatornow skips CR/LF that fall inside a quoted field. An unquoted CR is still honored as a separator, so old Mac line endings keep working, and explicitrow_seppaths are untouched.Added round-trip and detection tests in
test/csv/parse/test_row_separator.rb; the full suite stays green (527 tests, 4050 assertions). This is distinct from #107, which is about an explicit non-standardrow_sep.