Skip to content

Avoid per-row Enumerator#next in CSV#each #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
donoghuc wants to merge 1 commit into from
+10 −4
Closed

Avoid per-row Enumerator#next in CSV#each #362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions lib/csv.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2688,11 +2688,17 @@ def header_convert(name = nil, &converter)
# end
def each(&block)
return to_enum(__method__) unless block_given?
begin
while true
yield(parser_enumerator.next)
# Avoid per-row Enumerator#next (Fiber-backed, slow on JRuby) unless a
# #shift/#peek has already started pull-based iteration.
if @parser_enumerator.nil?
parser.parse(&block)
else
begin
while true
yield(@parser_enumerator.next)
end
rescue StopIteration
end
rescue StopIteration
end
end

Expand Down
Loading