Skip to content

fix: API schema drift detected (2026-09-04) - #39

Merged
royklo merged 1 commit into
mainfrom
api-drift/2026-09-04
Sep 4, 2026
Merged

fix: API schema drift detected (2026-09-04)#39
royklo merged 1 commit into
mainfrom
api-drift/2026-09-04

Conversation

@royklo

@royklo royklo commented Sep 4, 2026

Copy link
Copy Markdown
Owner

API Schema Drift Detected (Dev)

The nightly OpenAPI check found differences between https://uk.dev.inforcerdev.net/openapi.json and the stored snapshot.

--- /tmp/tmp.L8gTEGZD9x	2026-09-04 06:15:50.872644410 +0000
+++ /tmp/tmp.7jGQLMtb2u	2026-09-04 06:15:50.860644381 +0000
@@ -2309,6 +2309,11 @@
             "nullable": true,
             "type": "string"
           },
+          "membershipRule": {
+            "description": "The dynamic membership rule (only populated for groups whose groupTypes contains DynamicMembership)",
+            "nullable": true,
+            "type": "string"
+          },
           "visibility": {
             "description": "The visibility of the group (e.g., Public, Private)",
             "nullable": true,
Drift detected.

What's included

  • Updated docs/openapi-snapshot.json reflecting the current Dev spec

Next steps

  1. Review the diff above
  2. Push any cmdlet/alias/test/doc updates to this branch
  3. Merge once the production-ready label is added (means prod matches too)

Workflow run: https://github.com/royklo/Powershell-Module-Automation/actions/runs/33843637645

Copilot AI lite review requested due to automatic review settings September 4, 2026 06:15
@royklo royklo added the api-drift API schema drift label Sep 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a straightforward snapshot update that matches the reported OpenAPI drift and introduces no functional code changes.

Pull request overview

Updates the repository’s stored OpenAPI snapshot to match the current Dev environment spec after the nightly schema drift check detected a new field on the Group model.

Changes:

  • Added the membershipRule property to the Group schema in the stored OpenAPI snapshot (docs/openapi-snapshot.json).
File summaries
File Description
docs/openapi-snapshot.json Updates the stored OpenAPI snapshot to include the newly detected membershipRule field for groups.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@royklo royklo added the production-ready Changes verified on production label Sep 4, 2026
@royklo

royklo commented Sep 4, 2026

Copy link
Copy Markdown
Owner Author

Production Check Passed

Production OpenAPI spec now matches the snapshot on this branch — changes are live, safe to merge.


Workflow run: https://github.com/royklo/Powershell-Module-Automation/actions/runs/33847338720

@royklo
royklo merged commit 1fd4ddd into main Sep 4, 2026
4 checks passed
@royklo
royklo deleted the api-drift/2026-09-04 branch September 4, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-drift API schema drift production-ready Changes verified on production

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants