Fix Connext license use in the CI tests

[fgallegosalido]

Description

Currently, tests related to security require a special license not publicly available. This license is only used when running the CI installing Connext through RTI packages and only in x64 architectures.

This change allows the CI to use that same license when testing with Debian pacakges too in both x64 and aarch64.

Fixes ros2/rmw_connextdds#246

Is this user-facing behavior change?

Security tests using the Connext RMW can now be run using Connext Debian packages in both x64 and aarch64.

Did you use Generative AI?

No

Additional Information

[mergify]

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

• Queue this pull request

[fgallegosalido]

@ahcorde can you launch the following validations?

• x64 without debs
• x64 with debs
• aarch64 with debs

[knmcguire]

Hi!

I was looking at these test failures and saw that this PR was still untested. Ive made a port branch (as it needs to be part of this repo to test it out) and have setup some runs for you:

X64 - no debs:
X64 - with debs:
Aarchs64 - with debs:

Just double check if these are correct!

Also just confirm that I have correctly assumed that with no debs that you meant the ci argument CI_USE_CONNEXT_DEBS true or false.

[knmcguire]

Hmm sadly I see the same issues still as reported ros2/rmw_connextdds#246 so seems not to have solved it I'm afraid.

[fgallegosalido]

@knmcguire thank you for launching these validations! These are exactly the ones I need to test this.

That is strange. It seems either the environment variable RTI_LICENSE_FILE is not pointing to the correct license file or it is not getting set (although I think it is, as it is set in the same place as the build without Debians). I will investigate this and see if I can find out what is going on. If you can think of something else, let me know.

[knmcguire]

Perhaps we have to also set the NNDSHOME variable?

8: [RTI LICENSE ERROR] | RTI Security Plugins feature license not found: NDDSHOME = /opt/rti.com/rti_connext_dds-7.7.0/rti_license.dat.

And also this seems related? License Expired on 14-nov-2024

Here is the part that might be interesting from the logs but you can also check it from the ci logs if you are able to get those?

8: [RTI LICENSE] | RTI Connext licensed for prototype, research and non-commercial use only. USE FOR OTHER COMMERCIAL PURPOSES IS PROHIBITED. See RTI_License_Agreement_LM file for terms. For free tools and additional capabilities register at https://rti.com/ros - License issued to Non-Commercial and Prototype User [email protected] For non-production use only.
8: Please contact [email protected] with any questions or comments.
8: 
8: [RTI LICENSE ERROR] | RTI Security Plugins feature license not found: NDDSHOME = /opt/rti.com/rti_connext_dds-7.7.0/rti_license.dat.
8: License Expired on 14-nov-2024
8: Please contact [email protected] with any questions or comments.
8: 
8: ERROR [CREATE DP|LC:Discovery,Security] RTI_Security_PluginSuite_create:!precondition: There was a problem validating license for RTI Security Plugins.
8: Please contact [email protected] with any questions or comments.

[fgallegosalido]

Indeed, the license has already expired. It seems the non-debian build is fine because it is using Connext Pro, which does not need a license for the core libraries. However, the Debian packages do need a license, and the one provided inside them does not support security.

I will check internally this issue and will come back with a solution. Thank you @knmcguire!