Repository navigation
Conversation
- Trigger CI on push and pull requests to master (the default branch), instead of main/refactoring. - Type Check job: build mappit-core before type-checking the app, which imports its declarations from dist/. - Drop Node 18 from the test matrix: Vite 7 and electron-vite 5 require Node >= 20.19. Update engines and README accordingly. Co-Authored-By: Claude Opus 5.5 <[email protected]>
There was a problem hiding this comment.
🟡 Changes recommended
The change is a low-risk, internally consistent CI/config/docs update, but final human review of the default-branch switch to master is warranted since CI triggers depend on the repository's actual default branch, which can't be verified from the diff.
0 open findings
What changed in this PR
This PR fixes the two failing CI jobs from the last run by correcting build ordering and Node version support. The Type Check job failed because packages/app was type-checked without first building packages/core (whose compiled declarations the app resolves against), causing TS2307. The Test (Node 18) job failed because Vite 7 and electron-vite 5 require Node ^20.19.0 || >=22.12.0. The PR also retargets CI onto master, the new default branch.
Changes:
- Build
packages/corebefore type-checking in thetypecheckjob to resolvemappit-coredeclarations. - Drop Node 18 from the test matrix (now
[20, 22]) and bumpengines/README/badge to Node ≥ 20. - Switch CI
push/pull_requesttriggers frommain/refactoringtomaster.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Retargets triggers to master, drops Node 18 from the test matrix, and adds a core build step before the app/core typecheck. |
packages/core/package.json |
Raises the engines.node floor from >=18 to >=20. |
README.md |
Updates the Node badge and prerequisites to Node ≥ 20 (20.19 noted for Vite 7 / electron-vite 5). |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Summary
The last CI run (push to
refactoring, 2026-03-02) failed on two jobs. Both causes reproduced locally:packages/appwithout buildingmappit-corefirst, somappit-coreand its declarations are not found (TS2307). Fixed by building the core before type-checking.^20.19.0 || >=22.12.0. Node 18 is dropped from the matrix (now[20, 22]), andenginesand README are updated to Node ≥ 20.Also, CI now triggers on
master(now the default branch) instead ofmain/refactoring.Verification (local, clean clone)
npm ci,eslint packages/core/src packages/app/src: 0 errors (3 unused-variable warnings)npm run build+npm run test(core): 16 files, 155 tests passedtypecheckcore and app: pass after building core; app fails withTS2307without it🤖 Generated with Claude Code