Repository navigation
ci: require lockfile for dependency installs - #27
Merged
Merged
Conversation
rogerchappel
marked this pull request as ready for review
October 5, 2026 14:54
rogerchappel
enabled auto-merge (rebase)
October 5, 2026 14:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Require
package-lock.jsonfor CI dependency installation and fail with a clear diagnostic when absent. Install dependencies exclusively withnpm cito ensure reproducible resolution.Verification
npm cinpm test(45 tests passed)npm run checknpm run smokenpm run release:workflow-checkgit diff --checkRisk Level
Notes: CI-only behavior change. Pull request/push workflow runs validation; release workflow is tag-triggered only and is not triggered by this branch push or draft PR.
Rollback Plan
Revert commit
8877c72.Human Decision Needed
Commit-by-commit changes
8877c72 ci: require lockfile for dependency installs— replace the optionalnpm installfallback with an explicit lockfile requirement andnpm ci.