Skip to content

test: certify Dapper 2.1.89 interoperability - #296

Closed
rodri-oliveira-dev wants to merge 1 commit into
fix/dateonly-timeonly-materializationfrom
test/dapper-2.1.89-compatibility
Closed

rodri-oliveira-dev wants to merge 1 commit into
fix/dateonly-timeonly-materializationfrom
test/dapper-2.1.89-compatibility

Conversation

@rodri-oliveira-dev

Copy link
Copy Markdown
Owner

Summary

  • certify Dapper 2.1.89 DynamicParameters delegation through mapped sync and async queries, including nulls, literals, explicit DbType, size, precision/scale and SQL Server output parameters
  • add provider-backed DateOnly/TimeOnly evidence for SQL Server (DateTime/TimeSpan), PostgreSQL/Npgsql 10 (native DateOnly/TimeOnly) and SQLite (ISO text plus explicit converters), comparing runtime and strict-generated materialization
  • preserve the strict-generated GeneratedParameters boundary and explicitly reject DynamicParameters there
  • cover Dommel InsertMapped*/UpdateMapped* date/time writes, nullable fields, write converters and Dapper binding
  • extend the strict-generated SQLite AOT smoke with DateOnly/TimeOnly and nullable values without adding reflection
  • reset Dapper TypeHandlers between provider certification cases so Dommel registration cannot leak across scenarios

Provider matrix

Provider New date/time evidence Generated evidence DynamicParameters evidence
SQL Server datetime2 -> DateOnly, time(3) -> TimeOnly, nulls and millisecond precision strict-generated parity input/output, DbType, decimal precision/scale
PostgreSQL / Npgsql 10 native DateOnly / TimeOnly, nulls and millisecond precision strict-generated parity existing parameterized provider suite
SQLite ISO text with explicit converters, nulls and millisecond precision strict-generated parity plus AOT smoke sync/async, literals, nulls, DbType, size
MySQL / MariaDB / Oracle / Firebird existing regression suite only; no new date/time compatibility claim existing provider coverage existing provider coverage

Validation

  • dotnet restore ./Dapper.FluentMap.slnx
  • dotnet build ./Dapper.FluentMap.slnx --configuration Release --no-restore — 0 warnings, 0 errors
  • dotnet test ./Dapper.FluentMap.slnx --configuration Release --no-build — 658 total, 583 passed, 75 expected external-provider skips, 0 failed
  • SQL Server 2022 CU23 provider suite in Docker with strict certification — 22/22 passed
  • PostgreSQL 18.6 / Npgsql 10 provider suite in Docker with strict certification — 22/22 passed
  • strict-generated SQLite smoke — generated:ok
  • Native AOT restore and dependency builds — 0 warnings, 0 errors
  • Native AOT publish reached ILCompiler with all configured IL diagnostics treated as errors, then stopped because the local machine lacks the Visual C++ Desktop linker workload; CI remains the published-binary execution proof

Compatibility

No production API or implementation changes. GeneratedParameters remains the only accepted parameter collection for strict-generated queries. No blanket Native AOT or unsupported provider date/time claim is introduced.

Stack / merge order

This PR is intentionally based on #295, which is based on the Dapper 2.1.89 compatibility-contract work. Merge the baseline work first, then #295, then this PR. Do not merge this PR before its base.

Refs #294
Relates to #295
Upstream: DapperLib/Dapper#2225, DapperLib/Dapper#2228, DapperLib/Dapper#2233

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T03:42:46.487410Z 088550f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 088550f4ec

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-actions

Copy link
Copy Markdown
Contributor

SonarQube Cloud success

The SonarQube Cloud Quality Gate passed for this PR.

Quality Gate status: OK

Metric Status Actual Threshold
new_reliability_rating OK 1 1
new_security_rating OK 1 1
new_maintainability_rating OK 1 1
new_duplicated_lines_density OK 0.0 3
new_security_hotspots_reviewed OK 100.0 100

@codecov

codecov Bot commented Oct 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@rodri-oliveira-dev

Copy link
Copy Markdown
Owner Author

Consolidado no PR #298. O comentário de revisão sobre restauração do estado global Dommel foi corrigido, respondido e resolvido no conjunto consolidado.

rodri-oliveira-dev added a commit that referenced this pull request Oct 29, 2026
…ver-governance

Prepare FluentMap 3.6.1 and establish semantic versioning governance.

- Set Dapper 2.1.89 as the minimum supported version.
- Align DateOnly/TimeOnly conversions across runtime and generated materializers.
- Expand interoperability, provider compatibility and Native AOT tests.
- Synchronize versioning across all five NuGet packages.
- Add a semantic versioning skill and automated validation, preventing unauthorized major upgrades.
- Update compatibility, migration and release documentation in English and Portuguese.
- Consolidate PRs #291, #295, #296 and #297.

Refs #294.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant