Skip to content

rocks dump escape xml tag #9

Description

@lclementi

rocks dump does too much escaping with attributes:

rocks set host attr compute-0-0-0 attr=cpu_match value="host-passthrough: <topology sockets='2' cores='8' threads='1'/><numa><cell cpus='0-7' memory='29360128'/><cell cpus='8-15' memory='29360128'/></numa>"

rocks list host attr compute-0-0-0 | grep cpu_match
    compute-0-0-0: cpu_match                         host-passthrough: <topology sockets='2' cores='8' threads='1'/><numa><cell cpus='0-7' memory='29360128'/><cell cpus='8-15' memory='29360128'/></numa>    

rocks dump host attr compute-0-0-0
/opt/rocks/bin/rocks add host attr compute-0-0-0 cpu_match host-passthrough:\ \<topology\ sockets=\'2\'\ cores=\'8\'\ threads=\'1\'/\>\<numa\>\<cell\ cpus=\'0-7\'\ memory=\'29360128\'/\>\<cell\ cpus=\'8-15\'\ memory=\'29360128\'/\>\</numa\>

rocks dump should use the parameter and the double quote e.g.:
value="aldkfkjdfk"

This should also be updated in the KVM users guide which report a bad example for the XML attribute.

Clem

@tcooper

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions