Add conversation_link pass-through field to Holmes chat params - #2163
Add conversation_link pass-through field to Holmes chat params#2163ezra-robusta wants to merge 1 commit into
Conversation
extra=allow already forwarded unknown fields to Holmes; declaring the field documents the contract: the URL of the surface a chat originated from, which Holmes renders into its system prompt so PRs/issues it creates link back. Co-Authored-By: Claude <[email protected]> Claude-Session: https://claude.ai/code/session_01E7e2epGfemL5yPs3cA6nhN
|
|
|
✅ Docker image ready for
Use this tag to pull the image for testing. 📋 Copy commandsgcloud auth configure-docker us-central1-docker.pkg.dev
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/robusta-runner:e424dda
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/robusta-runner:e424dda me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:e424dda
docker push me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:e424ddaPatch Helm values in one line: helm upgrade --install robusta robusta/robusta \
--reuse-values \
--set runner.image=me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:e424dda |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. WalkthroughThe Holmes chat parameter and request models now accept an optional ChangesHolmes conversation link support
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized change adds an optional conversation link without altering existing behavior, and no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
What
Adds an optional
conversation_linkfield toHolmesChatParams(src/robusta/core/model/base_params.py) andHolmesChatRequest(src/robusta/core/reporting/holmes.py). It carries the URL of the surface a chat originated from (Slack thread permalink, Teams message link, platform chat/workflow-run URL); Holmes renders it into its system prompt so any PR/MR/issue it creates links back to the originating conversation.Pure pass-through — no behavior change in robusta itself. Old Holmes versions ignore the field; new Holmes validates it before rendering (shape + origin allowlist) — see the holmesgpt PR.
Companion PRs in holmesgpt (prompt rendering + validation), relay (link construction per chat surface), and robusta-frontend (platform chat URLs). Relay PR: robusta-dev/relay#748.
🤖 Generated with Claude Code
https://claude.ai/code/session_01F5Lu9XsDRPWEANCEg9hYDS