Skip to content

Add conversation_link pass-through field to Holmes chat params - #2163

Open
ezra-robusta wants to merge 1 commit into
masterfrom
claude/holmes-pr-conversation-links-ktnbu3
Open

Add conversation_link pass-through field to Holmes chat params#2163
ezra-robusta wants to merge 1 commit into
masterfrom
claude/holmes-pr-conversation-links-ktnbu3

Conversation

@ezra-robusta

@ezra-robusta ezra-robusta commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

What

Adds an optional conversation_link field to HolmesChatParams (src/robusta/core/model/base_params.py) and HolmesChatRequest (src/robusta/core/reporting/holmes.py). It carries the URL of the surface a chat originated from (Slack thread permalink, Teams message link, platform chat/workflow-run URL); Holmes renders it into its system prompt so any PR/MR/issue it creates links back to the originating conversation.

Pure pass-through — no behavior change in robusta itself. Old Holmes versions ignore the field; new Holmes validates it before rendering (shape + origin allowlist) — see the holmesgpt PR.

Companion PRs in holmesgpt (prompt rendering + validation), relay (link construction per chat surface), and robusta-frontend (platform chat URLs). Relay PR: robusta-dev/relay#748.

🤖 Generated with Claude Code

https://claude.ai/code/session_01F5Lu9XsDRPWEANCEg9hYDS

extra=allow already forwarded unknown fields to Holmes; declaring the field
documents the contract: the URL of the surface a chat originated from, which
Holmes renders into its system prompt so PRs/issues it creates link back.

Co-Authored-By: Claude <[email protected]>
Claude-Session: https://claude.ai/code/session_01E7e2epGfemL5yPs3cA6nhN
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown

Docker image ready for e424dda (built in 3m 52s)

⚠️ Warning: does not support ARM (ARM images are built on release only - not on every PR)

Use this tag to pull the image for testing.

📋 Copy commands

⚠️ Temporary images are deleted after 30 days. Copy to a permanent registry before using them:

gcloud auth configure-docker us-central1-docker.pkg.dev
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/robusta-runner:e424dda
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/robusta-runner:e424dda me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:e424dda
docker push me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:e424dda

Patch Helm values in one line:

helm upgrade --install robusta robusta/robusta \
  --reuse-values \
  --set runner.image=me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:e424dda

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b615b342-a89d-4feb-a70b-790aecd87ede

📥 Commits

Reviewing files that changed from the base of the PR and between 7c76938 and 849341f.

📒 Files selected for processing (2)
  • src/robusta/core/model/base_params.py
  • src/robusta/core/reporting/holmes.py

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


Walkthrough

The Holmes chat parameter and request models now accept an optional conversation_link field. The field stores the originating Slack, Teams, chat, or workflow URL.

Changes

Holmes conversation link support

Layer / File(s) Summary
Conversation link contract
src/robusta/core/model/base_params.py, src/robusta/core/reporting/holmes.py
HolmesChatParams and HolmesChatRequest now define optional conversation_link fields with None defaults and documentation for originating conversation URLs.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 84934

This localized change adds an optional conversation link without altering existing behavior, and no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the main change: adding a conversation_link pass-through field to Holmes chat parameters.
Description check ✅ Passed The description directly explains the added conversation_link fields, their purpose, and the unchanged Robusta behavior.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/holmes-pr-conversation-links-ktnbu3

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants