Skip to content

fix: port player fixes from michei69/pear-desktop - #45

Merged
bercedev merged 6 commits into
masterfrom
fix/player-fork-fixes-2
Nov 16, 2026
Merged

bercedev merged 6 commits into
masterfrom
fix/player-fork-fixes-2

Conversation

@bercedev

Copy link
Copy Markdown
Member

Ported one fix from michei69/pear-desktop, the other three didn't fit.

Ported

  • SponsorBlock now clears old segments when a new track loads (videodatachange → dataloaded) instead of on a late emptied, so a slow emptied can't wipe the next track's segments. From michei69/pear-desktop@34afb88.

Skipped

  • playback-recovery (4bceae5): YourTune has no playback-recovery plugin, so nothing to fix.
  • audio-compressor rebind (2c3d85e): the fix depends on the fork's audio-graph provider and chain code, which YourTune doesn't have.
  • crossfade (549c62a): YourTune's crossfade is a different design (fader.ts, separate audio element). The fork's fadeInGain and isAutoTransition state aren't there.

Tests
The source commit had no tests, so none added. In Podman (offline after install): lint 0 errors / 20 warnings, typecheck and build pass, oxfmt clean, pnpm test 94 pass / 1 fail (the known Electron-launch one).

Not tested live in the app.

A late emptied event could clear the next track's cached segments and disable skipping.

ported from michei69/pear-desktop@34afb888c2 (MIT)
The startup fetch can resolve before the first dataloaded. Segments now carry their video id; dataloaded clears only a set for another video, and a late result for an old video is dropped.
At dataloaded the id comes from the event payload first, then getVideoData(); with no id the set is kept. A result that arrives while the playing id is unknown is parked and applied at the next dataloaded only if it matches.
@github-actions

Copy link
Copy Markdown

🚀 Build Artifacts Ready!

The builds have completed successfully. You can download the artifacts from the workflow run:

📦 Download Artifacts

Available builds:

  • Windows: build-artifacts-windows-latest
  • macOS: build-artifacts-macos-latest
  • Linux: build-artifacts-ubuntu-latest

Note: Artifacts are available for 7 days.

@github-actions

Copy link
Copy Markdown

🚀 Build Artifacts Ready!

The builds have completed successfully. You can download the artifacts from the workflow run:

📦 Download Artifacts

Available builds:

  • Windows: build-artifacts-windows-latest
  • macOS: build-artifacts-macos-latest
  • Linux: build-artifacts-ubuntu-latest

Note: Artifacts are available for 7 days.

@bercedev
bercedev merged commit fce3639 into master Nov 16, 2026
7 checks passed
@github-actions

Copy link
Copy Markdown

🚀 Build Artifacts Ready!

The builds have completed successfully. You can download the artifacts from the workflow run:

📦 Download Artifacts

Available builds:

  • Windows: build-artifacts-windows-latest
  • macOS: build-artifacts-macos-latest
  • Linux: build-artifacts-ubuntu-latest

Note: Artifacts are available for 7 days.

@github-actions

Copy link
Copy Markdown

🚀 Build Artifacts Ready!

The builds have completed successfully. You can download the artifacts from the workflow run:

📦 Download Artifacts

Available builds:

  • Windows: build-artifacts-windows-latest
  • macOS: build-artifacts-macos-latest
  • Linux: build-artifacts-ubuntu-latest

Note: Artifacts are available for 7 days.

@github-actions

Copy link
Copy Markdown

🚀 Build Artifacts Ready!

The builds have completed successfully. You can download the artifacts from the workflow run:

📦 Download Artifacts

Available builds:

  • Windows: build-artifacts-windows-latest
  • macOS: build-artifacts-macos-latest
  • Linux: build-artifacts-ubuntu-latest

Note: Artifacts are available for 7 days.

@github-actions

Copy link
Copy Markdown

🚀 Build Artifacts Ready!

The builds have completed successfully. You can download the artifacts from the workflow run:

📦 Download Artifacts

Available builds:

  • Windows: build-artifacts-windows-latest
  • macOS: build-artifacts-macos-latest
  • Linux: build-artifacts-ubuntu-latest

Note: Artifacts are available for 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant