Repository navigation
fix: port player fixes from michei69/pear-desktop - #45
Conversation
A late emptied event could clear the next track's cached segments and disable skipping. ported from michei69/pear-desktop@34afb888c2 (MIT)
The startup fetch can resolve before the first dataloaded. Segments now carry their video id; dataloaded clears only a set for another video, and a late result for an old video is dropped.
At dataloaded the id comes from the event payload first, then getVideoData(); with no id the set is kept. A result that arrives while the playing id is unknown is parked and applied at the next dataloaded only if it matches.
🚀 Build Artifacts Ready!The builds have completed successfully. You can download the artifacts from the workflow run: Available builds:
Note: Artifacts are available for 7 days. |
🚀 Build Artifacts Ready!The builds have completed successfully. You can download the artifacts from the workflow run: Available builds:
Note: Artifacts are available for 7 days. |
🚀 Build Artifacts Ready!The builds have completed successfully. You can download the artifacts from the workflow run: Available builds:
Note: Artifacts are available for 7 days. |
🚀 Build Artifacts Ready!The builds have completed successfully. You can download the artifacts from the workflow run: Available builds:
Note: Artifacts are available for 7 days. |
🚀 Build Artifacts Ready!The builds have completed successfully. You can download the artifacts from the workflow run: Available builds:
Note: Artifacts are available for 7 days. |
🚀 Build Artifacts Ready!The builds have completed successfully. You can download the artifacts from the workflow run: Available builds:
Note: Artifacts are available for 7 days. |
Ported one fix from michei69/pear-desktop, the other three didn't fit.
Ported
videodatachange→dataloaded) instead of on a lateemptied, so a slowemptiedcan't wipe the next track's segments. From michei69/pear-desktop@34afb88.Skipped
fadeInGainandisAutoTransitionstate aren't there.Tests
The source commit had no tests, so none added. In Podman (offline after install): lint 0 errors / 20 warnings, typecheck and build pass, oxfmt clean,
pnpm test94 pass / 1 fail (the known Electron-launch one).Not tested live in the app.