Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2500 +/- ##
=======================================
Coverage 85.45% 85.45%
=======================================
Files 125 125
Lines 23042 23042
=======================================
Hits 19691 19691
Misses 3351 3351 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ronaldtse
left a comment
There was a problem hiding this comment.
Thank you @TJ-91 for this careful update and for the clear explanation. The renumbering to the code points agreed in the Working Group last call is contained to the algorithm enum, every other use site references the enumerators by name, and the new test vectors are self-consistent with the -05 assignments, including the detached signatures and the encrypt-and-sign combinations. The continuous integration runs are green for this pull request apart from the known upstream fuzzing leg. I am approving it on behalf of @ronaldtse, and reviews from @ni4 and @antonsviridenko are kindly requested before the merge.
This aligns to https://datatracker.ietf.org/doc/draft-ietf-openpgp-nist-bp-comp/05/ and reflects what is agreed upon in the OpenPGP WG's WGLC for the document. It is unlikely to change now. Includes the test vectors and adds them to the existing PQC tests.
Usually I would advise to wait for the RFC until merging the changes, however, the code is not enabled by default so I think it can be justified to merge it already.