Skip to content

Update PQC NIST-BP Composite to -05: Non-experimental code point assignment - #2500

Open
TJ-91 wants to merge 2 commits into
rnpgp:mainfrom
TJ-91:pqc-nist-bp-final
Open

TJ-91 wants to merge 2 commits into
rnpgp:mainfrom
TJ-91:pqc-nist-bp-final

Conversation

@TJ-91

@TJ-91 TJ-91 commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

This aligns to https://datatracker.ietf.org/doc/draft-ietf-openpgp-nist-bp-comp/05/ and reflects what is agreed upon in the OpenPGP WG's WGLC for the document. It is unlikely to change now. Includes the test vectors and adds them to the existing PQC tests.

Usually I would advise to wait for the RFC until merging the changes, however, the code is not enabled by default so I think it can be justified to merge it already.

@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.45%. Comparing base (26482f6) to head (bf369ae).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2500   +/-   ##
=======================================
  Coverage   85.45%   85.45%           
=======================================
  Files         125      125           
  Lines       23042    23042           
=======================================
  Hits        19691    19691           
  Misses       3351     3351           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ronaldtse ronaldtse left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @TJ-91 for this careful update and for the clear explanation. The renumbering to the code points agreed in the Working Group last call is contained to the algorithm enum, every other use site references the enumerators by name, and the new test vectors are self-consistent with the -05 assignments, including the detached signatures and the encrypt-and-sign combinations. The continuous integration runs are green for this pull request apart from the known upstream fuzzing leg. I am approving it on behalf of @ronaldtse, and reviews from @ni4 and @antonsviridenko are kindly requested before the merge.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants