Repository navigation
ci: allow a small coverage drift in the codecov project status - #2497
Merged
Merged
Conversation
The aggregated coverage report is assembled from uploads of many CI legs across backends and platforms, and rounding differences between those uploads shift the project percentage by a few hundredths of a point. This makes the strict zero-drift project gate fail on pull requests that do not reduce coverage, for example #2489 and #2492. A 0.1 percent threshold absorbs the aggregate noise while genuine regressions still fail the check.
Contributor
Author
|
@ni4 This small CI change lets the codecov project status tolerate the few-hundredths-of-a-point rounding drift that comes from aggregating uploads across many CI legs, which currently fails pull requests such as #2489 and #2492 even though their patch coverage passes. A review from you is kindly requested whenever your time allows, and thank you for all of the reviews today. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2497 +/- ##
=======================================
Coverage 85.45% 85.45%
=======================================
Files 125 125
Lines 23042 23043 +1
=======================================
+ Hits 19691 19692 +1
Misses 3351 3351 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Merging with single approval as pure CI change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a small threshold to the codecov project status so that rounding differences between coverage uploads no longer fail the check.
The aggregated coverage report is assembled from uploads of many CI legs across backends and platforms. Rounding differences between those uploads shift the project percentage by a few hundredths of a point, and the default zero-drift gate turns this into a failure even when a pull request does not reduce coverage. Pull requests #2489 and #2492 both failed the project status with drifts of 0.03 and 0.01 percent respectively while their patch coverage passed, which shows the gate is reacting to aggregate noise rather than to the changes under review.
The change sets the project target to
autowith a threshold of 0.1 percent. Aggregate noise of this magnitude is absorbed, while a genuine coverage regression larger than 0.1 percent still fails the check as before. The patch status is left at its default, so every added line remains held to the existing standard.This is a CI and process change, so @ni4 a review from you is kindly requested whenever your time allows. Thank you.