Fix the surfaces the redesign left unverified: terminal money, rounding parity, drift labels, print - #4
Merged
Conversation
`jeval threshold` gains --currency, and both it and `jeval report` print per-case costs and the segment table through jeval.currency: "KRW 1,738 per case" rather than a bare "1,738" or "1,737.70". Signed-off-by: rlaope <[email protected]>
Python rounded a 12.5% share to even and the slider rounded it up, so the impact table and the live readout under it disagreed by a point; shares now go through jeval.currency.format_percent, which rounds a tie away from zero like toFixed. The slider also receives the cost curve at full precision instead of six decimals. The report prints as a labelled three-page summary instead of eleven pages of height-capped charts. A node-run parity test covers shares as well as money. Signed-off-by: rlaope <[email protected]>
Two slices of one question were both labelled "department", and the model-change label and the last slice's name ran off the right edge. Each slice now carries its model and n, points sit inside the plot, and the drift charts sit on plates like the rest of the report. Signed-off-by: rlaope <[email protected]>
The example report is rebuilt with the documented command; it is now 292 KB because the slider's curve is embedded at full precision. Signed-off-by: rlaope <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jeval threshold --currencyis new.jeval thresholdandjeval reportnow print costs throughjeval.currency(KRW 1,738 per case) instead of a bare1,738or1,737.70.toFixed, so the table and the live readout can no longer differ by a point at 12.5%. The slider gets the cost curve at full precision. The node parity test now also covers shares.Test plan
uv run pytestpasses;ruff format --check,ruff checkandmypyare clean.examples/make-drift-log.pydata and checked in light and dark mode.jeval threshold --currency krw --by langoutput was checked by hand and is covered by a regression test.