Skip to content

Build the PS1 target hard-float again - #7

Merged
rixnobis merged 1 commit into
mainfrom
drop-soft-float
Oct 1, 2026
Merged

rixnobis merged 1 commit into
mainfrom
drop-soft-float

Conversation

@rixnobis

@rixnobis rixnobis commented Oct 1, 2026 •

Copy link
Copy Markdown
Owner

Reverts #5. Since #6, string.format no longer converts to double, and liblua built without -msoft-float disassembles identically to the soft-float build: 0 cop1 instructions, no soft-float helper calls (abed030, before #5 and #6, had 4). The flag now only buys 29 "uses -msoft-float" ld warnings in psyqo-lua's hello example, whose exe is byte-identical either way.

Discussion on pcsx-redux/nugget#62, which drops its own soft-float change.

Summary by CodeRabbit

  • Chores
    • Updated the PlayStation build configuration. The remaining compiler and linker settings are unchanged.
    • No end-user-facing changes are included in this update.

Since string.format stopped converting to double, nothing in liblua
emits a cop1 instruction either way: built without -msoft-float it
disassembles identically. Keeping the flag only makes ld warn about
mixed float ABIs in every hard-float program that links liblua.

This reverts commit 360b1cb.
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 99a2ad58-a5bb-4295-bf6a-ad51b7548eee

📥 Commits

Reviewing files that changed from the base of the PR and between d95b6f1 and 9dc7311.

📒 Files selected for processing (1)
  • src/Makefile
💤 Files with no reviewable changes (1)
  • src/Makefile

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The PSX build no longer adds -msoft-float to ARCHFLAGS. The other PSX compiler and linker settings remain unchanged.

Changes

PSX build settings

Layer / File(s) Summary
PSX compiler flags
src/Makefile
Removes the PSX-specific -msoft-float flag and its comment. Other PSX compiler and linker settings remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 9dc73

The PSX build drops the soft-float flag while retaining integer-based Lua arithmetic and formatting. No actionable regression was found; this is mergeable subject to normal build checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the PSX soft-float flag so the PS1 target builds with hard-float settings again.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@rixnobis
rixnobis merged commit b1f2991 into main Oct 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant