Repository navigation
Build the PS1 target hard-float again - #7
Conversation
Since string.format stopped converting to double, nothing in liblua emits a cop1 instruction either way: built without -msoft-float it disassembles identically. Keeping the flag only makes ld warn about mixed float ABIs in every hard-float program that links liblua. This reverts commit 360b1cb.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe PSX build no longer adds ChangesPSX build settings
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The PSX build drops the soft-float flag while retaining integer-based Lua arithmetic and formatting. No actionable regression was found; this is mergeable subject to normal build checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Reverts #5. Since #6, string.format no longer converts to double, and liblua built without
-msoft-floatdisassembles identically to the soft-float build: 0 cop1 instructions, no soft-float helper calls (abed030, before #5 and #6, had 4). The flag now only buys 29 "uses -msoft-float" ld warnings in psyqo-lua's hello example, whose exe is byte-identical either way.Discussion on pcsx-redux/nugget#62, which drops its own soft-float change.
Summary by CodeRabbit