Skip to content

string.format: refuse the float conversions #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rixnobis merged 1 commit into from
Oct 1, 2026
Merged

string.format: refuse the float conversions #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 6 additions & 21 deletions src/lstrlib.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,19 +804,6 @@ static int str_gsub (lua_State *L) {
#endif /* } */


/*
** LUA_FLTFRMLEN is the length modifier for float conversions in
** 'string.format'; LUA_FLTFRM_T is the float type corresponding to
** the previous length
*/
#if !defined(LUA_FLTFRMLEN)

#define LUA_FLTFRMLEN ""
#define LUA_FLTFRM_T double

#endif


/* maximum size of each formatted item (> len(format('%99.99f', -1e308))) */
#define MAX_ITEM 512
/* valid flags in a format specification */
Expand Down Expand Up @@ -932,14 +919,12 @@ static int str_format (lua_State *L) {
nb = luaI_sprintf(buff, form, ni);
break;
}
case 'e': case 'E': case 'f':
#if defined(LUA_USE_AFORMAT)
case 'a': case 'A':
#endif
case 'g': case 'G': {
addlenmod(form, LUA_FLTFRMLEN);
nb = luaI_sprintf(buff, form, (LUA_FLTFRM_T)luaL_checknumber(L, arg));
break;
case 'e': case 'E': case 'f': case 'F':
case 'a': case 'A': case 'g': case 'G': {
/* numbers are integers here, and there is no floating point */
return luaL_error(L, "invalid option " LUA_QL("%%%c") " to "
LUA_QL("format") " (no floating point)",
*(strfrmt - 1));
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}
case 'q': {
addquoted(L, &b, arg);
Expand Down
Loading