Use the x-access-token username form for cloned-repo credentials - #93
Open
manasip-prog wants to merge 1 commit into
Open
Use the x-access-token username form for cloned-repo credentials#93manasip-prog wants to merge 1 commit into
manasip-prog wants to merge 1 commit into
Conversation
manasip-prog
force-pushed
the
manasip/xrpld-token-url-form
branch
from
September 4, 2026 20:10
c990ef1 to
80d1162
Compare
Collaborator
Author
|
Verified on ripple/rippled-antithesis run 33918533062, which builds this branch against a GitHub App installation token: The xrpld clone succeeds with a The fuzzer clone in the same step fails, but on credentials rather than URL form — |
bthomee
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dockerfile.xrpldbuilt its authenticated clone URLs ashttps://<token>@github.com/..., which relies on the token being accepted as a bare username. That holds for personal access tokens but is not the form GitHub documents for GitHub App installation tokens, which ishttps://x-access-token:<token>@github.com/....ripple/rippled-antithesis#112 moves the xrpld checkout onto an App installation token, so
XRPLD_CREDENTIALSwill carry aghs_*token rather than a PAT. This switches both clone URLs to the documented form; it accepts PATs equally, so the fuzzer clone is unaffected either way.🤖 Generated with Claude Code