fix: sanitize HTML in MarkdownRenderer during SSR - #1247
Merged
Conversation
Remove SSR bypass that returned unsanitized HTML. DOMPurify now runs isomorphically on both server and client to prevent XSS attacks. - Remove typeof window check in MarkdownRenderer - Add tests verifying DOMPurify sanitization
|
@Benedict315 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove SSR bypass that returned unsanitized HTML. DOMPurify now runs isomorphically on both server and client to prevent XSS attacks.
Description
Fixed SSR XSS vulnerability in MarkdownRenderer by removing the bypass that returned unsanitized HTML during server-side rendering. DOMPurify now sanitizes HTML on both server and client. Added 2 security tests.
Related Issue
Closes #1047
Type of Change
Checklist