fix(hooks): stop IntersectionObserver recreating on every loading tog… - #1246
Merged
RUKAYAT-CODER merged 1 commit intoAug 26, 2026
Conversation
…gle (rinafcode#898) - Add loadingRef (synced to loading state via useEffect) so the observer callback can read the latest loading value without a dep on the state var. - Add runLoadMoreRef (updated on every render, no deps) so the observer callback always invokes the latest runLoadMore without listing it as a dep. - Remove loading and runLoadMore from the observer effect dep array; deps are now only [hasNextPage, rootMargin, threshold]. - Remove loading from runLoadMore's useCallback dep array (read via ref). Result: the IntersectionObserver is only torn down and recreated when hasNextPage, rootMargin, or threshold actually change — not on every loading state flip, which was causing missed/duplicate callbacks during rapid scrolling.
|
@abdulazizishaq212-prog Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: runLoadMore depended on loading via useCallback, and the observer effect depended on both. Every loading flip → new runLoadMore →
observer effect re-runs → observer torn down and recreated mid-scroll.
Fix — two refs break the chain:
dep.
Observer effect deps are now only: [hasNextPage, rootMargin, threshold] — the only things that should legitimately recreate the observer.
Branch fix/infinite-scroll-observer-recreate-898 is pushed. Use the PR description above when opening the PR on GitHub at the URL the push
printed.
closes #898