Skip to content

fix: stabilize socket connection callbacks - #1245

Merged
RUKAYAT-CODER merged 1 commit into
rinafcode:mainfrom
xtrial01:fix/stabilize-socket-connection-effect
Aug 26, 2026
Merged

fix: stabilize socket connection callbacks#1245
RUKAYAT-CODER merged 1 commit into
rinafcode:mainfrom
xtrial01:fix/stabilize-socket-connection-effect

Conversation

@xtrial01

Copy link
Copy Markdown

Summary

Stabilized socket connection lifecycle by using refs for parse/serialize callbacks and removing safeParse from the connection effect dependencies. This prevents inline callback functions from triggering unnecessary reconnects on every render.

Related Issue

Closes #899

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • No console errors
  • Uses Lucide icons consistently
  • Responsive design implemented
  • Starknet best practices followed

@drips-wave

drips-wave Bot commented Aug 26, 2026

Copy link
Copy Markdown

@xtrial01 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@RUKAYAT-CODER

Copy link
Copy Markdown
Contributor

Thank you for contributing to the project.

@RUKAYAT-CODER
RUKAYAT-CODER merged commit 21f6b99 into rinafcode:main Aug 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stabilize useWebSocket parse/serialize props to prevent reconnect thrashing

2 participants