fix(moderation): Enforce pagination bounds on content-reports list endpoint (#1306) - #1340
Merged
RUKAYAT-CODER merged 1 commit intoAug 26, 2026
Conversation
|
@boalambo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project |
Contributor
Author
Thank you for always, so much grateful. God bless you ma |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enforces sane pagination bounds on
src/moderation/reports/content-reports.controller.ts's list endpoint, so a client can no longer request an unbounded number of rows (memory/DoS and performance risk) or pass negative/non-numeric pagination values.Closes #1306
Changes
dto/list-content-reports-query.dto.tslimitfield with validatedpageandlimitfields using@IsInt,@Min,@Maxfromclass-validator.limitis capped atMAX_PAGE_SIZE(100) and defaults toDEFAULT_PAGE_SIZE(10) when omitted.pagedefaults to1and must be a positive integer.APP_CONSTANTSfor consistency with the rest of the codebase.content-reporting.service.tsskipfrompage/limitand passes bothtake/skipto the repository query, replacing the oldquery.limit ?? 50fallback that had no upper bound.Verification
npm run typecheckpasses with no errors.ListContentReportsQueryDtois already wired into the controller'slistReportshandler via@Query(), so validation runs through the app's globalValidationPipe.DEFAULT_PAGE_SIZE(10) andMAX_PAGE_SIZE(100) exist insrc/common/constants/app.constants.ts.Acceptance criteria
limitis rejected with 400 (@Max(MAX_PAGE_SIZE)).@IsInt,@Min(1)).