feat: enforce pagination bounds and document payments OpenAPI - #1338
Merged
RUKAYAT-CODER merged 1 commit intoAug 26, 2026
Merged
Conversation
- analytics: add validated GetEventsQueryDto (IsInt/Min/Max) bounding the events list page size to MAX_PAGE_SIZE; invalid values now 400 - gamification: add LeaderboardPaginationDto bounding leaderboard page size; replaces the unbounded ParseIntPipe params - invoices: add @ApiTags/@ApiOperation/@apiresponse and typed error docs - payouts: fill in missing 400/403/404/409 response annotations
|
@oladev2026-tech Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enforces pagination bounds on two list endpoints and completes OpenAPI documentation on the payments controllers.
GetEventsQueryDto(@IsInt/@Min/@Max) and applies it toGET /analytics/events. The page size is bounded toMAX_PAGE_SIZE, a sane default is applied when omitted, and invalid values (negative, zero, non-numeric, over-max) are rejected with400via the globalValidationPipe— the endpoint can no longer be asked to return an unbounded number of rows.LeaderboardPaginationDtowith the same bounds and applies it toGET /gamification/leaderboard, replacing the previously unboundedParseIntPipequery params.@ApiTags,@ApiOperation,@ApiParamand@ApiResponse(success + typed404) to both handlers, which previously had no OpenAPI annotations.400/403/404/409response annotations.Default and maximum page sizes are sourced from the documented
APP_CONSTANTS(DEFAULT_PAGE_SIZE/MAX_PAGE_SIZE) rather than magic numbers.Testing
pnpm run typecheckpnpm run lint:cipnpm run buildIssues
Closes #1311
Closes #1310
Closes #1308
Closes #1307