feat: rate-limit secrets endpoints and complete OpenAPI docs - #1335
Merged
RUKAYAT-CODER merged 1 commit intoAug 26, 2026
Merged
Conversation
- secrets: apply CustomThrottleGuard with THROTTLE presets (strict on rotation) and wire ThrottlerModule in SecretsModule; document 429 - dashboard: add typed response DTOs and per-endpoint @ApiResponse/4xx - ab-testing: add @ApiOperation/@ApiResponse/@ApiParam to all handlers - permissions: fill in missing 400/401/409 response docs
|
@Nimatstar Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens and documents several controller surfaces.
CustomThrottleGuardto every handler insecrets.controller.ts(strictest preset on secret rotation) and wiresThrottlerModuleinSecretsModule. Exceeding a limit now returns429with a structured message. Limits are taken from the documented, configurableTHROTTLEpresets rather than hardcoded magic numbers, and normal usage is unaffected.dashboard/dto/dashboard-response.dto.ts) and per-endpoint@ApiResponse(success + relevant4xx, plus class-level401/403) so the generated Swagger models render accurately.@ApiOperation,@ApiResponseand@ApiParamto every handler that was previously undocumented, keeping the existing schema examples.400/401/409response annotations.Testing
pnpm run typecheckpnpm run lint:cipnpm run buildIssues
Closes #1325
Closes #1319
Closes #1318
Closes #1314