Skip to content

Fix pagination bounds across list endpoints - #1333

Merged
RUKAYAT-CODER merged 1 commit into
rinafcode:mainfrom
Spycall:fix/pagination-bounds-spycall
Aug 26, 2026
Merged

Fix pagination bounds across list endpoints#1333
RUKAYAT-CODER merged 1 commit into
rinafcode:mainfrom
Spycall:fix/pagination-bounds-spycall

Conversation

@Spycall

@Spycall Spycall commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Enforce validated pagination bounds and consistent defaults across users, cohorts, achievements, and recommendations list endpoints.

Changes

  • Apply validated pagination DTOs with numeric, minimum, and maximum checks.
  • Enforce the shared default page size of 10 and maximum page size of 100.
  • Bound recommendation requests at their endpoint-specific maximum of 50.
  • Return bounded paginated cohort results and pass pagination through achievement list routes.
  • Update focused controller regression tests.

Validation

  • pnpm run build
  • pnpm run typecheck
  • pnpm run lint:dto
  • pnpm run format:check
  • 33 focused Jest tests passed

Fixes #1302
Fixes #1303
Fixes #1304
Fixes #1305

@drips-wave

drips-wave Bot commented Aug 26, 2026

Copy link
Copy Markdown

@Spycall Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@RUKAYAT-CODER

Copy link
Copy Markdown
Contributor

Thank you for contributing to the project.

@RUKAYAT-CODER
RUKAYAT-CODER merged commit 478454c into rinafcode:main Aug 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants