Repository navigation
test: recover orphaned suites and guard module registration - #119
Merged
Merged
Conversation
6 tasks done
Deploying jetpack with
|
| Latest commit: |
59aa670
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://82ff6963.jetpack-1ws.pages.dev |
| Branch Preview URL: | https://fix-orphaned-tests.jetpack-1ws.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recover the missing integration-test module registrations and update stale tests to current APIs. The complete suite increases from 915 to 1,011 passing test cases.
The broader audit also recovers CLI inventory/version checks, task-response tests, an empty handle-test placeholder, and the archived real local-connection tests. The latter now use isolated temporary directories and assert the actual transport contract: a nonzero command exit is carried in the command response. Private pacman action checks run beside their implementation as unit tests; cache/factory/visitor checks exercise their current interfaces rather than obsolete fields.
Add a textual registration guard for the conventional layout documented in tests/README.md, including same-basename file/directory cases. It does not interpret cfg, inline/path/generated modules, include!, or custom Cargo discovery; it is not proof of compilation, execution, or uniform coverage. Remove the dead-code suppression from the now-used shared run-state helper.
Review follow-up: CLI subprocess checks now assert multi-host/group reporting, sorted membership, blended variables, and missing-entry errors. Local identity is checked against id -un, including a subprocess with deliberately incorrect USER/USERNAME variables; LocalConnection now queries the effective process identity rather than trusting environment variables. Obsolete DisplayMode/visitor/cache fields were not restored as public API; their current behavior is exercised instead.
Closes #10.
Validation
Retested with current main, including native SSH host trust: the full local suite and every final-head CI check pass.