Skip to content

test: recover orphaned suites and guard module registration - #119

Merged
Zorlin merged 3 commits into
mainfrom
fix/orphaned-tests
Nov 6, 2026
Merged

Zorlin merged 3 commits into
mainfrom
fix/orphaned-tests

Conversation

@Zorlin

@Zorlin Zorlin commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Recover the missing integration-test module registrations and update stale tests to current APIs. The complete suite increases from 915 to 1,011 passing test cases.

The broader audit also recovers CLI inventory/version checks, task-response tests, an empty handle-test placeholder, and the archived real local-connection tests. The latter now use isolated temporary directories and assert the actual transport contract: a nonzero command exit is carried in the command response. Private pacman action checks run beside their implementation as unit tests; cache/factory/visitor checks exercise their current interfaces rather than obsolete fields.

Add a textual registration guard for the conventional layout documented in tests/README.md, including same-basename file/directory cases. It does not interpret cfg, inline/path/generated modules, include!, or custom Cargo discovery; it is not proof of compilation, execution, or uniform coverage. Remove the dead-code suppression from the now-used shared run-state helper.

Review follow-up: CLI subprocess checks now assert multi-host/group reporting, sorted membership, blended variables, and missing-entry errors. Local identity is checked against id -un, including a subprocess with deliberately incorrect USER/USERNAME variables; LocalConnection now queries the effective process identity rather than trusting environment variables. Obsolete DisplayMode/visitor/cache fields were not restored as public API; their current behavior is exercised instead.

Closes #10.

Validation

  • cargo test --locked: 1,011 passed
  • Deliberately added an unregistered fixture: the guard failed and named orphan.rs; removing the fixture restored the passing suite
  • cargo fmt --check and git diff --check: passed
  • cargo clippy --locked --all-targets -- -W clippy::all: succeeds with existing warnings
  • Real local transport tests run commands and file operations only inside isolated temporary directories

Retested with current main, including native SSH host trust: the full local suite and every final-head CI check pass.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Deploying jetpack with  Cloudflare Pages  Cloudflare Pages

Latest commit: 59aa670
Status: ✅  Deploy successful!
Preview URL: https://82ff6963.jetpack-1ws.pages.dev
Branch Preview URL: https://fix-orphaned-tests.jetpack-1ws.pages.dev

View logs

@Zorlin
Zorlin merged commit 7878783 into main Nov 6, 2026
12 checks passed
@Zorlin
Zorlin deleted the fix/orphaned-tests branch November 6, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests: several test files are never compiled/run (silent coverage gap)

1 participant