Repository navigation
Cookies: fix quoted Max-Age (#1334) and login redirect (#554), deprecate RFC 2109/2965 API - #1609
Merged
Merged
Conversation
…uoted in the Set-Cookie header. Issue #1334. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
…irection sent after a login. Issue #554. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Addresses the SonarCloud S6355 findings. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Max-AgeandPathof a version 1 cookie are no longer quoted inSet-Cookie, as browsers ignore quoted values.CookieAuthenticator.authenticated()returnsSTOPafter a login redirection, so the next restlet can't overwrite it.Cookie/CookieSettingversion, comment and the constructors taking them). It is removed in 3.0, see the companion PR.Test plan
./mvnw -B -pl org.restlet,org.restlet.ext.crypto verify -P default,test🤖 Generated with Claude Code